add MariaDB support

Author: LordSimal

.github/workflows/ci.yml

@@ -20,9 +20,21 @@ jobs:
             fail-fast: false
             matrix:
                 php-version: [ '8.1', '8.2', '8.3', '8.4' ]
-                db-type: [ sqlite, mysql, pgsql ]
+                db-type: [ sqlite, mysql, mariadb, pgsql ]
 
         services:
+            mariadb:
+                image: mariadb:11
+                env:
+                    MARIADB_ROOT_PASSWORD: root
+                    MARIADB_DATABASE: cakephp
+                ports:
+                    - 3307:3306
+                options: >-
+                    --health-cmd "mariadb-admin ping -h localhost -proot"
+                    --health-interval 10s
+                    --health-timeout 5s
+                    --health-retries 5
             postgres:
                 image: postgres:14
                 env:
@@ -44,6 +56,10 @@ jobs:
                     sudo service mysql start
                     mysql -h 127.0.0.1 -u root -proot -e 'CREATE DATABASE cakephp;'
 
+            -   name: Install MariaDB dump tools
+                if: matrix.db-type == 'mariadb'
+                run: sudo apt-get install mariadb-client
+
             -   name: Setup Postgres
                 if: matrix.db-type == 'pgsql'
                 run: |
@@ -57,7 +73,7 @@ jobs:
                 uses: shivammathur/setup-php@v2
                 with:
                     php-version: ${{ matrix.php-version }}
-                    extensions: mbstring, intl, pdo_${{ matrix.db-type }}
+                    extensions: mbstring, intl, ${{ matrix.db-type == 'sqlite' && 'pdo_sqlite' || matrix.db-type == 'pgsql' && 'pdo_pgsql' || 'pdo_mysql' }}
                     ini-values: zend.assertions=1
                     coverage: pcov
 
@@ -75,6 +91,9 @@ jobs:
                     if [[ ${{ matrix.db-type }} == 'mysql' ]]; then
                         export DB_URL=mysql://root:root@127.0.0.1/cakephp
                     fi
+                    if [[ ${{ matrix.db-type }} == 'mariadb' ]]; then
+                        export DB_URL=mysql://root:root@127.0.0.1:3307/cakephp
+                    fi
                     if [[ ${{ matrix.db-type }} == 'pgsql' ]]; then
                         export DB_URL=postgres://postgres:postgres@127.0.0.1/postgres
                     fi
@@ -107,7 +126,7 @@ jobs:
                 uses: ramsey/composer-install@v3
 
             -   name: Install PHP tools with phive.
-                run: "phive install --trust-gpg-keys 'CF1A108D0E7AE720,51C67305FFC2E5C0,12CE0F1D262429A5'"
+                run: "phive install --trust-gpg-keys '51C67305FFC2E5C0,12CE0F1D262429A5'"
 
             -   name: Run phpcs
                 if: always()
@@ -120,4 +139,3 @@ jobs:
             -   name: Run phpstan
                 if: always()
                 run: tools/phpstan analyse --error-format=github
-

README.md

@@ -47,7 +47,8 @@ public function bootstrap(): void
 
 For each DBMS you need to have its respective dump tool installed.
 
-- MySQL/MariaDB => `mysqldump`
+- MySQL => `mysqldump`
+- MariaDB => `mariadb-dump`
 - SQLite => `sqlite3`
 - PostgreSQL => `pg_dump`
 

src/Command/DumpSqlCommand.php

@@ -67,19 +67,15 @@ public function execute(Arguments $args, ConsoleIo $io): int
         }
 
         $driver = $connection->getDriver();
-        switch (get_class($driver)) {
-            case Mysql::class:
-                $object = new CakeDumpMySQL($connection->config());
-                break;
-            case Sqlite::class:
-                $object = new CakeDumpSqlite($connection->config());
-                break;
-            case Postgres::class:
-                $object = new CakeDumpPostgres($connection->config());
-                break;
-            default:
-                $message = sprintf('Unknown driver "%s" given.', get_class($driver));
-                throw new UnknownDriverException($message);
+        if ($driver instanceof Mysql) {
+            $object = new CakeDumpMySQL($connection->config(), $driver);
+        } elseif ($driver instanceof Sqlite) {
+            $object = new CakeDumpSqlite($connection->config());
+        } elseif ($driver instanceof Postgres) {
+            $object = new CakeDumpPostgres($connection->config());
+        } else {
+            $message = sprintf('Unknown driver "%s" given.', get_class($driver));
+            throw new UnknownDriverException($message);
         }
 
         $object->setIo($io);

src/Sql/MySQL.php

@@ -3,13 +3,27 @@
 
 namespace CakeDumpSql\Sql;
 
+use Cake\Database\Driver\Mysql as MysqlDriver;
 use CakeDumpSql\Error\BinaryNotFoundException;
 use Symfony\Component\Process\Process;
 
 class MySQL extends SqlBase
 {
     protected string $command = 'mysqldump';
 
+    /**
+     * @param array<string, mixed> $config The config array from the connection object
+     * @param \Cake\Database\Driver\Mysql $driver The current mysql driver instance
+     */
+    public function __construct(array $config, MysqlDriver $driver)
+    {
+        parent::__construct($config);
+
+        if ($driver->isMariadb()) {
+            $this->command = 'mariadb-dump';
+        }
+    }
+
     /**
      * @return string
      * @throws \CakeDumpSql\Error\BinaryNotFoundException