Skip to content

tp: very large stack frames in trajectory planner #4049

@BsAtHome

Description

@BsAtHome

While looking at the output from the RTAI build I saw these:

/home/runner/work/linuxcnc/linuxcnc/src/emc/tp/tp.c: In function ‘tpHandleBlendArc.isra’:
/home/runner/work/linuxcnc/linuxcnc/src/emc/tp/tp.c:2136:1: warning: the frame size of 6528 bytes is larger than 2048 bytes [-Wframe-larger-than=]
/home/runner/work/linuxcnc/linuxcnc/src/emc/tp/tp.c: In function ‘tpAddCircle’:
/home/runner/work/linuxcnc/linuxcnc/src/emc/tp/tp.c:2302:1: warning: the frame size of 5584 bytes is larger than 2048 bytes [-Wframe-larger-than=]
/home/runner/work/linuxcnc/linuxcnc/src/emc/tp/tp.c: In function ‘tpAddLine’:
/home/runner/work/linuxcnc/linuxcnc/src/emc/tp/tp.c:2207:1: warning: the frame size of 5584 bytes is larger than 2048 bytes [-Wframe-larger-than=]
/home/runner/work/linuxcnc/linuxcnc/src/emc/tp/tp.c: In function ‘tpAddRigidTap’:
/home/runner/work/linuxcnc/linuxcnc/src/emc/tp/tp.c:1696:1: warning: the frame size of 5584 bytes is larger than 2048 bytes [-Wframe-larger-than=]

A 5..6kB stack frame looks a bit overkill. Part of it may have been introduced with the new TP, but I'm not sure.
@grandixximo, maybe you know more about this? You have been in this code before. Are these stack frames required to be so large?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions