Skip to content

Emitter off bug on promise tracker HOC #86

@brauliodiez

Description

@brauliodiez

This issue was fixed on the hook version, in the HOC seems not to be fixed:

 componentWillUnmount() {
    emitter.off(promiseCounterUpdateEventId);
 }

We have two options to fix this:

  • Fix the HOC version.
  • Make the HOC version to use internally the hooks version.

The second version could be the cleanest one, we didn't use it in the past just in case somebody was using an older React version to let them use this by copy pasting, IMHO now it doesn't makes sense.

I would go for the second option.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions