Skip to content

Better propagation of an 'id' when used with our input components #535

@danparnella

Description

@danparnella

Issue

  • Relevant Comment Thread in artlook-client
  • Currently, when an id is passed into a non-group type input component (like Checkbox), that ends up being applied to the LabelComponent along with the input itself.
  • When an id is passed into a group type input component (like RadioGroup), that ends up being applied to LabelComponent that wraps the whole group, as well as each LabelComponent for each radio input component.

Proposal

  • Don't apply the id to the LabelComponent, keep it only on the input itself for non-group type input components
  • Ignore the id entirely for group type input components (as the id value for these inputs needs to be set programmatically)
  • I didn't audit every input component so there may be differences not surfaced here

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions