Issue 54062: Strip folder name from displayed name a file field

Author: XingY

src/org/labkey/test/tests/AttachmentFieldTest.java

@@ -91,9 +91,9 @@ public void testFileFieldInSampleType()
 
         clickAndWait(Locator.tagWithText("a", "S1"));
         clickAndWait(Locator.tagWithClass("a", "labkey-text-link").withText("edit"));
-        waitForElement(Locator.tagContainingText("div", "sampletype/jpg_sample.jpg"));
+        waitForElement(Locator.tagContainingText("div", "jpg_sample.jpg"));
         // Issue 53200: Update form incorrectly shows that a file is not available
-        assertTextNotPresent("sampletype/jpg_sample.jpg (unavailable)");
+        assertTextNotPresent("jpg_sample.jpg (unavailable)");
         clickButton("Cancel");
 
         log("Verifying view in browser works");

src/org/labkey/test/tests/FileAttachmentColumnTest.java

@@ -613,7 +613,7 @@ private void validateAssayRun(String assayName, String folderPath, String runNam
         checker().withScreenshot("unexpected_run_file_links")
                 .wrapAssertion(()-> Assertions.assertThat(runFileTexts.stream().map(String::trim).toList())
                         .as("expect complete run files")
-                        .containsOnly(String.format("assaydata%s%s", File.separatorChar, runFile.getName()))
+                        .containsOnly(runFile.getName())
                         .hasSize(5));
     }
 
@@ -637,7 +637,7 @@ private void validateDatasetData(String datasetName, String folderPath, List<Fil
             }
             else
             {
-                Optional<WebElement> optionalFileLink = Locator.linkContainingText(String.format("datasetdata%s%s", File.separatorChar, file.getName()))
+                Optional<WebElement> optionalFileLink = Locator.linkContainingText(file.getName())
                         .findOptionalElement(dataRegionTable);
                 checker().withScreenshot("unexpected_file_state")
                         .awaiting(Duration.ofSeconds(2),

src/org/labkey/test/tests/InlineImagesAssayTest.java

@@ -182,10 +182,7 @@ public final void testAssayInlineImages() throws Exception
         customizeView.addColumn(FieldKey.fromParts("Run", "RowId"));
         customizeView.addColumn(FieldKey.fromParts("Run", "Protocol", "RowId"));
         customizeView.applyCustomView();
-        var protocolId = list.getDataAsText(0, "Run/Protocol/RowId");
-        var runId = list.getDataAsText(0, "Run/RowId");
-        String helpJpgFilePath = String.format("AssayId_%s%sRunId_%s%s%s", protocolId, File.separatorChar,
-                runId, File.separatorChar, HELP_JPG_FILE.getName());
+        String helpJpgFilePath = HELP_JPG_FILE.getName();
 
         log("Validate that two links to this image file are now present.");
         assertElementPresent("Did not find the expected number of icons for images for " + PNG01_FILE.getName() + " from the runs.", Locator.xpath("//img[contains(@title, '" + PNG01_FILE.getName() + "')]"), 3);
@@ -206,8 +203,8 @@ public final void testAssayInlineImages() throws Exception
 
             log("Validate that the 'File' (last) column is as expected.");
             assertEquals("Values in 'File' column not exported as expected [" + exportedFile.getName() + "]",
-                    Arrays.asList("Batch File Field", "assaydata" + File.separator + XLS_FILE.getName(), "assaydata" + File.separator + XLS_FILE.getName(), "assaydata" + File.separator + XLS_FILE.getName()),
-                    ExcelHelper.getColumnData(workbook.getSheetAt(workbook.getActiveSheetIndex()), 7));
+                    Arrays.asList("Batch File Field", XLS_FILE.getName(), XLS_FILE.getName(), XLS_FILE.getName()),
+                    ExcelHelper.getColumnData(workbook.getSheetAt(workbook.getActiveSheetIndex()), 7));//
         }
 
         log("Remove the 'File' (last) column from the batch and see that things still work.");
@@ -286,7 +283,7 @@ private void validateExcelExport(File exportedFile, Workbook workbook, String he
 
         exportedColumn = ExcelHelper.getColumnData(sheet, 5);
         assertEquals("Values in 'File' column not exported as expected [" + exportedFile.getName() + "]",
-                Arrays.asList("Run File Field", "assaydata" + File.separator + PNG01_FILE.getName(), "assaydata" + File.separator + PNG01_FILE.getName(), "assaydata" + File.separator + PNG01_FILE.getName()),
+                Arrays.asList("Run File Field", PNG01_FILE.getName(), PNG01_FILE.getName(), PNG01_FILE.getName()),
                 exportedColumn);
 
     }

src/org/labkey/test/tests/core/admin/AllowedFileExtensionTest.java

@@ -383,7 +383,7 @@ public void testAllowedFileExtensionsInSampleType()
         {
             fieldMap = Map.of("Name", String.format("S-%d", i), stFileField, fileMap.get(allowedType).getAbsolutePath());
             sampleTypeHelper.insertRow(fieldMap);
-            expectedValues.add(String.format(" sampletype%s%s", File.separator, fileMap.get(allowedType).getName()));
+            expectedValues.add(String.format(" %s", fileMap.get(allowedType).getName()));
             i++;
         }