Fix various intermittent test issues (#2776)

- Disable pipeline triggers after failed tests
- Avoid mousing over editable grid headers
- Fix actionUrlTest.js to not use advanced JS method (`endsWith`)
- Handle page load when signing in
- Improve `WebDriverWrapper.mouseOut`
- Improve `QueryGrid` synchronization

Author: labkey-tchad

modules/simpletest/resources/scripts/validationTest/actionUrlTest.js

@@ -21,7 +21,9 @@ function doTest()
 
     if (contextPath.length > 0) {
         var baseUrl = LABKEY.ActionURL.getBaseURL();
-        if (!baseUrl.endsWith(contextPath + "/"))
+        var suffix = contextPath + "/";
+        var idx = baseUrl.indexOf(suffix);
+        if (idx === -1 || idx !== baseUrl.length - suffix.length)
             errors[errors.length] = new Error("ActionURL.getBaseURL() = " + baseUrl);
     }
 

src/org/labkey/test/LabKeySiteWrapper.java

@@ -405,11 +405,14 @@ public void attemptSignIn(String email, String password)
         setFormElement(Locator.id("email"), email);
         setFormElement(Locator.id("password"), password);
         WebElement signInButton = Locator.lkButton("Sign In").findElement(getDriver());
-        signInButton.click();
-        shortWait().until(ExpectedConditions.invisibilityOfElementLocated(Locator.byClass("signing-in-msg")));
-        shortWait().until(ExpectedConditions.or(
-                ExpectedConditions.stalenessOf(signInButton), // Successful login
-                ExpectedConditions.presenceOfElementLocated(Locators.labkeyError.withText()))); // Error during sign-in
+        doAndMaybeWaitForPageToLoad(10_000, () -> {
+            signInButton.click();
+            shortWait().until(ExpectedConditions.invisibilityOfElementLocated(Locator.byClass("signing-in-msg")));
+            shortWait().until(ExpectedConditions.or(
+                    ExpectedConditions.stalenessOf(signInButton), // Successful login
+                    ExpectedConditions.presenceOfElementLocated(Locators.labkeyError.withText()))); // Error during sign-in
+            return ExpectedConditions.stalenessOf(signInButton).apply(null);
+        });
     }
 
     public void signInShouldFail(String email, String password, String... expectedMessages)

src/org/labkey/test/Locators.java

@@ -30,6 +30,7 @@ private Locators() { }
     public static final Locator.XPathLocator folderTab = Locator.tagWithClass("div", "lk-nav-tabs-ct").append(Locator.tagWithClass("ul", "lk-nav-tabs")).childTag("li");
     public static final Locator.XPathLocator panelWebpartTitle = Locator.byClass("labkey-wp-title-text");
     public static final Locator.XPathLocator folderTitle = Locator.tagWithClass("a", "lk-body-title-folder");
+    public static final Locator.XPathLocator loadingSpinner = Locator.byClass("fa-spinner");
 
     public static Locator.XPathLocator headerContainer()
     {

src/org/labkey/test/TestScrubber.java

@@ -20,6 +20,7 @@
 import org.labkey.remoteapi.Connection;
 import org.labkey.remoteapi.SimplePostCommand;
 import org.labkey.test.components.html.Checkbox;
+import org.labkey.test.components.pipeline.PipelineTriggerWizard;
 import org.labkey.test.pages.core.admin.AllowedFileExtensionAdminPage;
 import org.labkey.test.pages.core.admin.BaseSettingsPage;
 import org.labkey.test.pages.core.admin.ConfigureFileSystemAccessPage;
@@ -160,6 +161,16 @@ public void cleanSiteSettings()
             TestLogger.error("Failed to reset site look and feel properties after test.", e);
         }
 
+        try
+        {
+            // Disable all pipeline triggers so that they don't show up as memory leaks in subsequent tests.
+            PipelineTriggerWizard.disableAllPipelineTriggers(createDefaultConnection());
+        }
+        catch (Exception e)
+        {
+            TestLogger.error("Failed to disable pipeline triggers after test", e);
+        }
+
     }
 
     @LogMethod(quiet = true)

src/org/labkey/test/WebDriverWrapper.java

@@ -3000,14 +3000,17 @@ public void selectFolderTreeItem(String folderName)
 
     /**
      * Move mouse to the upper left corner of the document to dismiss tooltips and the like
-     * Will scroll page if necessary
      */
     public void mouseOut()
     {
         try
         {
-            scrollToTop();
-            new Actions(getDriver()).moveToLocation(0, 0).perform();
+            new Actions(getDriver())
+                    .moveToLocation(0, 0)
+                    // Add a little wiggle to make sure tooltips notice
+                    .moveByOffset(4, 4)
+                    .moveByOffset(-2, -2)
+                    .perform();
         }
         catch (WebDriverException ignore) { }
     }

src/org/labkey/test/components/domain/DomainDesigner.java

@@ -48,7 +48,7 @@ public class ElementCache extends BaseDomainDesigner<?>.ElementCache
         protected final DomainPanel<?, ?> propertiesPanel = new DomainPanel.DomainPanelFinder(getDriver()).index(0)
                 .timeout(WAIT_FOR_JAVASCRIPT).findWhenNeeded(this);
         protected final DomainFormPanel fieldsPanel = new DomainFormPanel.DomainFormPanelFinder(getDriver())
-                .index(getFieldPanelIndex()).timeout(1000).findWhenNeeded();
+                .index(getFieldPanelIndex()).timeout(2_000).findWhenNeeded();
 
         protected int getFieldPanelIndex()
         {

src/org/labkey/test/components/pipeline/PipelineTriggerWizard.java

@@ -16,6 +16,10 @@
 package org.labkey.test.components.pipeline;
 
 import org.jetbrains.annotations.NotNull;
+import org.labkey.remoteapi.CommandException;
+import org.labkey.remoteapi.Connection;
+import org.labkey.remoteapi.query.ContainerFilter;
+import org.labkey.remoteapi.query.Filter;
 import org.labkey.test.Locator;
 import org.labkey.test.WebDriverWrapper;
 import org.labkey.test.WebTestHelper;
@@ -24,11 +28,14 @@
 import org.labkey.test.components.html.Checkbox;
 import org.labkey.test.components.html.Input;
 import org.labkey.test.components.html.OptionSelect;
+import org.labkey.test.util.query.QueryApiHelper;
 import org.openqa.selenium.Alert;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.ui.ExpectedConditions;
 
+import java.io.IOException;
+import java.util.List;
 import java.util.Map;
 
 import static org.junit.Assert.assertTrue;
@@ -61,6 +68,18 @@ public static PipelineTriggerWizard beginAt(WebDriverWrapper driver, String cont
         return new PipelineTriggerWizard(driver.getDriver());
     }
 
+    public static void disableAllPipelineTriggers(Connection connection) throws IOException, CommandException
+    {
+        QueryApiHelper queryApiHelper = new QueryApiHelper(connection, "/", "pipeline", "TriggerConfigurations");
+        List<Map<String, Object>> triggers = queryApiHelper.selectRows(List.of("rowId", "enabled"),
+            List.of(new Filter("enabled", true)), List.of(), ContainerFilter.AllFolders).getRows();
+        if (!triggers.isEmpty())
+        {
+            triggers.forEach(trigger -> trigger.put("enabled", false));
+            queryApiHelper.updateRows(triggers);
+        }
+    }
+
     @Override
     public WebElement getComponentElement()
     {

src/org/labkey/test/components/ui/grids/EditableGrid.java

@@ -1160,6 +1160,8 @@ public String getErrorPopoverText(int row, CharSequence columnIdentifier)
      */
     public String getCellPopoverText(int row, CharSequence columnIdentifier)
     {
+        dismissPopover(); // Other popovers can block the target cell
+        getWrapper().mouseOver(Locator.tag("td").findElement(getRow(row))); // Avoid passing over any header cells on the way to the target cell
         WebElement cellDiv = Locator.tagWithClass("div", "cellular-display").findElement(getCell(row, columnIdentifier));
         getWrapper().mouseOver(cellDiv);   // cause the tooltip to be present
         return Optional.ofNullable(WebDriverWrapper.waitFor(()-> Locators.popover.findElementOrNull(getDriver()), 1000))
@@ -1170,7 +1172,9 @@ public String getCellPopoverText(int row, CharSequence columnIdentifier)
     public void dismissPopover()
     {
         Locators.popover.findOptionalElement(getDriver()).ifPresent(popover -> {
+            getWrapper().mouseOver(popover);
             getWrapper().mouseOut();
+            getWrapper().mouseOver(elementCache().getGridHeaderManager().getColumnHeader(0).getElement());
             getWrapper().shortWait().until(ExpectedConditions.invisibilityOf(popover));
         });
     }

src/org/labkey/test/components/ui/grids/FieldSelectionDialog.java

@@ -400,6 +400,7 @@ public FieldSelectionDialog removeAllSelectedFields()
                 continue;
             }
 
+            getWrapper().mouseOver(removeIcon);
             removeIcon.click();
         }
 

src/org/labkey/test/components/ui/grids/QueryGrid.java

@@ -221,18 +221,18 @@ public QueryGrid waitForRecordCount(int expectedCount, int milliseconds)
     @Override
     public void doAndWaitForUpdate(Runnable func)
     {
-        waitForLoaded();
-        Optional<WebElement> optionalStatus = elementCache().selectionStatusContainerLoc.findOptionalElement(elementCache());
+        super.doAndWaitForUpdate(() ->
+        {
+            WebElement status = hasSelectColumn() ? Locators.selectionStatusContainerLoc.waitForElement(this, 5_000) : null;
 
-        func.run();
+            func.run();
 
-        optionalStatus.ifPresent(el -> {
-            getWrapper().shortWait().until(ExpectedConditions.stalenessOf(el));
-            elementCache().selectionStatusContainerLoc.waitForElement(this, 5_000);
+            if (status != null)
+            {
+                getWrapper().shortWait().until(ExpectedConditions.stalenessOf(status));
+                Locators.selectionStatusContainerLoc.waitForElement(this, 5_000);
+            }
         });
-
-        waitForLoaded();
-        clearElementCache();
     }
 
 
@@ -789,19 +789,24 @@ protected ElementCache elementCache()
         return (ElementCache) super.elementCache();
     }
 
+    protected static class Locators
+    {
+        static final Locator.XPathLocator selectionStatusContainerLoc = Locator.byClass("selection-status");
+    }
+
     protected class ElementCache extends ResponsiveGrid<QueryGrid>.ElementCache
     {
+
         final GridBar gridBar = new GridBar.GridBarFinder().findWhenNeeded(QueryGrid.this);
 
-        WebElement saveViewButton = Locator.button("Save").findWhenNeeded(getDriver());
+        final WebElement saveViewButton = Locator.button("Save").findWhenNeeded(getDriver());
 
         final BootstrapMenu viewMenu = new MultiMenu.MultiMenuFinder(getDriver()).withText("Views").findWhenNeeded(this);
 
-        final Locator.XPathLocator selectionStatusContainerLoc = Locator.tagWithClass("div", "selection-status");
-        final Locator selectAllBtnLoc = selectionStatusContainerLoc.append(Locator.tagWithClass("span", "selection-status__select-all")
-                .child(Locator.buttonContainingText("Select")));
-        final Locator clearBtnLoc = selectionStatusContainerLoc.append(Locator.byClass("selection-status__clear-all")
-                .child(Locator.tag("button")));
+        final Locator selectAllBtnLoc = Locators.selectionStatusContainerLoc.append(Locator.byClass("selection-status__select-all")
+            .childTag("button"));
+        final Locator clearBtnLoc = Locators.selectionStatusContainerLoc.append(Locator.byClass("selection-status__clear-all")
+            .childTag("button"));
 
         final WebElement filterStatusPanel = Locator.css("div.grid-panel__filter-status").findWhenNeeded(this);