Constants for many commonly used role names in tests (#853)

Author: labkey-jeckels

snprc_scheduler/test/src/org/labkey/test/tests/snprc_scheduler/SNPRC_schedulerTest.java

@@ -40,6 +40,8 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 import static org.labkey.remoteapi.query.Filter.Operator.EQUAL;
+import static org.labkey.test.util.PermissionsHelper.EDITOR_ROLE;
+import static org.labkey.test.util.PermissionsHelper.READER_ROLE;
 
 @Category({EHR.class, SNPRC.class})
 @BaseWebDriverTest.ClassTimeout(minutes = 45)
@@ -115,8 +117,8 @@ private void doSetup()
         _permissionsHelper.addUserToProjGroup(EDITOR_USER.getEmail(), PROJECT_NAME, SecurityGroup.EDITOR.name);
 
         // set folder permission for groups
-        _permissionsHelper.addMemberToRole(SecurityGroup.READER.name, "Reader", PermissionsHelper.MemberType.group);
-        _permissionsHelper.addMemberToRole(SecurityGroup.EDITOR.name, "Editor", PermissionsHelper.MemberType.group);
+        _permissionsHelper.addMemberToRole(SecurityGroup.READER.name, READER_ROLE, PermissionsHelper.MemberType.group);
+        _permissionsHelper.addMemberToRole(SecurityGroup.EDITOR.name, EDITOR_ROLE, PermissionsHelper.MemberType.group);
 
         // add groups to roles
         _permissionsHelper.addMemberToRole(SecurityGroup.READER.name, SecurityRole.READER.name, PermissionsHelper.MemberType.group);