-
Notifications
You must be signed in to change notification settings - Fork 7
Closed
Description
Migrate overrides of deprecated method renderGridCellContents(RenderContext, Writer, HtmlWriter) to renderGridCellContents(RenderContext, HtmlWriter); use HtmlWriter, DOM, and builders. https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=52881
These PRs collectively migrate 63 method implementations to use safe HTML-generation and the new signature.
All PRs are merged
- Migrate to renderGridCellContents(RenderContext, HtmlWriter) #6671
- Code review @labkey-nicka
- Manual testing not necessary, IMO: simply adds a new method PopupMenu.render(HtmlWriter) variant to support TargetedMS PR below
- TC and merge
- Migrate to renderGridCellContents(RenderContext, HtmlWriter) targetedms#1077
- Code review @labkey-jeckels
- Manual testing @labkey-jeckels
- TC and merge
- Migrate to renderGridCellContents(RenderContext, HtmlWriter) MacCossLabModules#552
- Code review @vagisha
- Manual testing not necessary, IMO: whitespace changes only
- TC and merge
- Migrate to renderGridCellContents(RenderContext, HtmlWriter) customModules#226
- Code review @labkey-nicka
- Manual testing of viscstudies DatasetListWithStatusColumn @labkey-adam
- TC and merge
- https://github.com/LabKey/premiumModules/pull/260
- Code review @labkey-jeckels
- Manual testing of TransformBaseTable.StatusColumn @labkey-adam
- TC and merge
- https://github.com/LabKey/clientModules/pull/22
- Workflow changes
- Code review changes @labkey-nicka
- Manual testing not necessary, IMO: a single hand-coded
<A>tag replaced by a simple LinkBuilder call, in functionality that's not used by any client
- NLP changes
- Code review of NLP changes @XingY
- Manual testing not necessary, IMO: automated tests exercise this functionality, not used by any client. Code reviewer Xing agrees with this assessment.
- TC and merge
- Workflow changes
- Migrate to renderGridCellContents(RenderContext, HtmlWriter) nircEHRModules#543
- Code review @labkey-martyp
- Manual testing @labkey-martyp
- TC and merge
- Migrate to renderGridCellContents(RenderContext, HtmlWriter) ehrModules#957
- Code review @labkey-martyp
- Manual testing of
SNOMEDCodesDisplayColumn@labkey-martyp - Review and delete unused
org.labkey.api.ehr.table.VetReviewDisplayColumn - TC and merge
- https://github.com/LabKey/johnsHopkinsEHRModules/pull/473
- Code review @labkey-martyp
- Manual testing @labkey-martyp
- TC and merge
- Migrate to renderGridCellContents(RenderContext, HtmlWriter) commonAssays#889
- Code review @labkey-matthewb
- Code review updates @labkey-adam
- Manual testing of Flow display column changes @labkey-chrisj
- Manual testing of Luminex display column changes @labkey-chrisj
- TC and merge
- Migrate to renderGridCellContents(RenderContext, HtmlWriter) wnprc-modules#821
- Code review @labkey-martyp
- Manual testing @labkey-martyp
- WNPRC review @labkey-martyp
- TC and merge
- Migrate to renderGridCellContents(RenderContext, HtmlWriter) onprcEHRModules#1359
- Code review @labkey-martyp
- Migrate
org.labkey.api.ehr.table.VetReviewDisplayColumnto use DOM/builders @labkey-martyp - Manual testing @labkey-martyp
- ONPRC review @labkey-martyp
- TC and merge
Metadata
Metadata
Assignees
Labels
No labels