Fix Issue 48466 (#62)

select_rows: Set default max_rows to -1

Author: labkey-alan

CHANGE.txt

@@ -2,6 +2,12 @@
 LabKey Python Client API News
 +++++++++++
 
+What's New in the LabKey 2.6.1 package
+==============================
+
+*Release date: 10/09/2023*
+- Query API - Change max_rows default value to -1 in select_rows
+
 What's New in the LabKey 2.6.0 package
 ==============================
 

labkey/__init__.py

@@ -14,6 +14,6 @@
 # limitations under the License.
 #
 __title__ = "labkey"
-__version__ = "2.6.0"
+__version__ = "2.6.1"
 __author__ = "LabKey"
 __license__ = "Apache License 2.0"

labkey/query.py

@@ -316,7 +316,7 @@ def select_rows(
     filter_array: List[QueryFilter] = None,
     container_path: str = None,
     columns=None,
-    max_rows: int = None,
+    max_rows: int = -1,
     sort: str = None,
     offset: int = None,
     container_filter: str = None,
@@ -339,7 +339,7 @@ def select_rows(
     :param filter_array: set of filter objects to apply
     :param container_path: folder path if not already part of server_context
     :param columns: set of columns to retrieve
-    :param max_rows: max number of rows to retrieve
+    :param max_rows: max number of rows to retrieve, defaults to -1 (unlimited)
     :param sort: comma separated list of column names to sort by, prefix a column with '-' to sort descending
     :param offset: number of rows to offset results by
     :param container_filter: enumeration of the various container filters available. See:
@@ -522,7 +522,7 @@ def select_rows(
         filter_array: List[QueryFilter] = None,
         container_path: str = None,
         columns=None,
-        max_rows: int = None,
+        max_rows: int = -1,
         sort: str = None,
         offset: int = None,
         container_filter: str = None,

test/unit/test_query_api.py

@@ -365,7 +365,7 @@ def setUp(self):
         self.service = MockSelectRows()
         self.expected_kwargs = {
             "expected_args": [self.service.get_server_url()],
-            "data": {"schemaName": schema, "query.queryName": query},
+            "data": {"schemaName": schema, "query.queryName": query, "query.maxRows": -1},
             "headers": None,
             "timeout": 300,
         }