Skip to content

Commit 75d5b11

Browse files
authored
fix ehr data validation queries (#670)
1 parent 2664345 commit 75d5b11

File tree

4 files changed

+12
-20
lines changed

4 files changed

+12
-20
lines changed
Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11

2-
SELECT DISTINCT dam AS Id,
3-
gender,
4-
species
2+
SELECT Id.parents.dam AS parent,
3+
gender,
4+
species
55
FROM demographics
6-
WHERE dam IN (SELECT sire FROM demographics)
7-
8-
UNION
9-
10-
SELECT DISTINCT sire AS Id,
11-
gender,
12-
species
13-
FROM demographics
14-
WHERE sire IN (SELECT dam FROM demographics);
6+
WHERE Id.parents.dam IN (SELECT Id.parents.sire FROM demographics)

ehr/resources/queries/study/parentsDifferentSpecies.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ SELECT
1414
ELSE FALSE
1515
END as parentSpeciesMismatch
1616
FROM demographics d1
17-
LEFT JOIN demographics d2 ON d1.dam = d2.Id
18-
LEFT JOIN demographics d3 ON d1.sire = d3.Id
17+
LEFT JOIN demographics d2 ON d1.Id.parents.dam = d2.Id
18+
LEFT JOIN demographics d3 ON d1.Id.parents.sire = d3.Id
1919
) d4
2020
WHERE d4.parentSpeciesMismatch = TRUE

ehr/resources/queries/study/parentsIncorrectGender.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ SELECT
1414
ELSE FALSE
1515
END as parentSpeciesMismatch
1616
FROM demographics d1
17-
LEFT JOIN demographics d2 ON d1.dam = d2.Id
18-
LEFT JOIN demographics d3 ON d1.sire = d3.Id
17+
LEFT JOIN demographics d2 ON d1.Id.parents.dam = d2.Id
18+
LEFT JOIN demographics d3 ON d1.Id.parents.sire = d3.Id
1919
) d4
2020
WHERE d4.parentSpeciesMismatch = TRUE

ehr/resources/queries/study/parentsYoungerThanOffspring.sql

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ FROM (
55
dem.gender,
66
dem.species,
77
dem.birth,
8-
dem.dam,
8+
dem.Id.parents.dam,
99
damDem.birth as damBirth,
10-
dem.sire,
10+
dem.Id.parents.sire,
1111
sireDem.birth as sireBirth
1212
FROM demographics dem
13-
LEFT JOIN demographics damDem ON dem.dam = damDem.Id
14-
LEFT JOIN demographics sireDem ON dem.sire = sireDem.Id
13+
LEFT JOIN demographics damDem ON dem.Id.parents.dam = damDem.Id
14+
LEFT JOIN demographics sireDem ON dem.Id.parents.sire = sireDem.Id
1515
) t
1616
WHERE (t.birth <= t.damBirth OR t.birth <= t.sireBirth)

0 commit comments

Comments
 (0)