fixing a compilation error that I don't understand since it implements the interface...

Sigmonia · Sigmonia · commit 130821f8dcf6 · 2025-04-08T14:47:01.000-07:00
diff --git a/genotyping/src/org/labkey/genotyping/galaxy/WorkflowCompletionMonitor.java b/genotyping/src/org/labkey/genotyping/galaxy/WorkflowCompletionMonitor.java
@@ -128,8 +128,10 @@ public void run()
                             String analysisId = (String) props.get("analysis");
                             LOG.info("Detected completion file for analysis {}; attempting to signal LabKey Server at {}", analysisId, url);
 
-                            try (HttpClient client = HttpClient.newHttpClient())
+                            HttpClient client = null;
+                            try
                             {
+                                client = HttpClient.newHttpClient();
                                 HttpRequest request = HttpRequest.newBuilder()
                                         .uri(URI.create(url))
                                         .POST(HttpRequest.BodyPublishers.noBody())
@@ -140,6 +142,12 @@ public void run()
 
                                 LOG.info("LabKey response to analysis {} completion: \"{}\"", analysisId, message);
                             }
+                            finally
+                            {
+                                // Unclear to me why this can't be used with the try-with-resources...
+                                if (client != null)
+                                    client.close();
+                            }
                         }
                         catch (Throwable t)
                         {

Original file line number	Diff line number	Diff line change
`@@ -128,8 +128,10 @@ public void run()`
`128`	`128`	`String analysisId = (String) props.get("analysis");`
`129`	`129`	`LOG.info("Detected completion file for analysis {}; attempting to signal LabKey Server at {}", analysisId, url);`
`130`	`130`
`131`		`- try (HttpClient client = HttpClient.newHttpClient())`
	`131`	`+ HttpClient client = null;`
	`132`	`+ try`
`132`	`133`	`{`
	`134`	`+ client = HttpClient.newHttpClient();`
`133`	`135`	`HttpRequest request = HttpRequest.newBuilder()`
`134`	`136`	`.uri(URI.create(url))`
`135`	`137`	`.POST(HttpRequest.BodyPublishers.noBody())`
`@@ -140,6 +142,12 @@ public void run()`
`140`	`142`
`141`	`143`	`LOG.info("LabKey response to analysis {} completion: \"{}\"", analysisId, message);`
`142`	`144`	`}`
	`145`	`+ finally`
	`146`	`+ {`
	`147`	`+ // Unclear to me why this can't be used with the try-with-resources...`
	`148`	`+ if (client != null)`
	`149`	`+ client.close();`
	`150`	`+ }`
`143`	`151`	`}`
`144`	`152`	`catch (Throwable t)`
`145`	`153`	`{`