Skip to content

Commit 9a328f3

Browse files
committed
Updated comments in test.
1 parent 510f118 commit 9a328f3

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

panoramapublic/test/src/org/labkey/test/tests/panoramapublic/PanoramaPublicMakePublicTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,19 @@ public void testExperimentCopy()
5050
// Verify that a folder admin in the source folder, who is not the submitter or lab head will not see the
5151
// "Make Public" button in the Panorama Public copy.
5252
verifyMakePublicButtonIsNotVisible(PANORAMA_PUBLIC, targetFolder, ADMIN_2,
53-
"Make Public button should not be visible to a non-submitter and non-lab head user in the Panorama Public copy");
53+
"Make Public button should not be visible in the Panorama Public copy to a user who is neither submitter nor lab head");
5454

5555
// Verify that the submitter can make the data public
5656
verifyMakePublic(PANORAMA_PUBLIC, targetFolder, SUBMITTER, true);
5757

5858
// Resubmit the folder. This is still possible since the Panorama Public copy is not yet associated with a publication.
5959
resubmitFolder(projectName, folderName, SUBMITTER, true);
6060

61-
// Data copy is pending. Verify that the "Make Public" button in not available in the source folder or the copied folder
61+
// Data copy is pending. Verify that the "Make Public" button in not visible in the source folder or the copied folder
6262
verifyMakePublicButtonIsNotVisible(PANORAMA_PUBLIC, targetFolder, SUBMITTER,
63-
"Make Public button should not be visible in the Panorama Public copy for submitter if data copy is pending");
63+
"Make Public button should not be visible in the Panorama Public copy if data copy is pending");
6464
verifyMakePublicButtonIsNotVisible(projectName, folderName, SUBMITTER,
65-
"Make Public button should not be visible in the Panorama Public copy for submitter if data copy is pending");
65+
"Make Public button should not be visible in the source folder if data copy is pending");
6666

6767
// Verify that the submitter cannot enter the MakePublicAction URL in the browser to make the data public
6868
verifyCannotMakePublicPendingResubmit(PANORAMA_PUBLIC, targetFolder, SUBMITTER); // In the target folder
@@ -297,7 +297,7 @@ private void verifyMakePublic(String projectName, String folderName, String user
297297
stopImpersonating();
298298
}
299299

300-
private void verifyMakePublicButtonVisible(boolean visible, String projectName, String folderName, String user, String errorMessage)
300+
private void verifyMakePublicButtonVisible(boolean expectVisible, String projectName, String folderName, String user, String errorMessage)
301301
{
302302
if (isImpersonating())
303303
{
@@ -308,7 +308,7 @@ private void verifyMakePublicButtonVisible(boolean visible, String projectName,
308308
goToDashboard();
309309
TargetedMsExperimentWebPart expWebPart = new TargetedMsExperimentWebPart(this);
310310

311-
if (visible)
311+
if (expectVisible)
312312
{
313313
assertTrue(errorMessage, expWebPart.hasMakePublicButton());
314314
}

0 commit comments

Comments
 (0)