Use PageFlowUtil.jsString to escape container path.

vagisha · vagisha · commit 0dfd6f002c4b · 2025-03-13T11:36:09.000-07:00
diff --git a/panoramapublic/src/org/labkey/panoramapublic/query/ExperimentAnnotationsTableInfo.java b/panoramapublic/src/org/labkey/panoramapublic/query/ExperimentAnnotationsTableInfo.java
@@ -162,7 +162,10 @@ public void renderGridCellContents(RenderContext ctx, Writer out) throws IOExcep
                                             .at(src, PageFlowUtil.staticResourceUrl("_images/plus.gif"))),
                                     HtmlString.NBSP)
                                     .appendTo(out);
-                            pageConfig.addHandler(spanId, "click", "viewExperimentDetails(this,'" + container.getPath() + "', '" + id + "','" + detailsPage + "')");
+                            pageConfig.addHandler(spanId, "click", "viewExperimentDetails(this,"
+                                    + PageFlowUtil.jsString(container.getPath())
+                                    + ", '" + id + "', "
+                                    + PageFlowUtil.jsString(detailsPage) + ")");
                         }
                         super.renderGridCellContents(ctx, out);
                     }

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,10 @@ public void renderGridCellContents(RenderContext ctx, Writer out) throws IOExcep`
`162`	`162`	`.at(src, PageFlowUtil.staticResourceUrl("_images/plus.gif"))),`
`163`	`163`	`HtmlString.NBSP)`
`164`	`164`	`.appendTo(out);`
`165`		`- pageConfig.addHandler(spanId, "click", "viewExperimentDetails(this,'" + container.getPath() + "', '" + id + "','" + detailsPage + "')");`
	`165`	`+ pageConfig.addHandler(spanId, "click", "viewExperimentDetails(this,"`
	`166`	`+ + PageFlowUtil.jsString(container.getPath())`
	`167`	`+ + ", '" + id + "', "`
	`168`	`+ + PageFlowUtil.jsString(detailsPage) + ")");`
`166`	`169`	`}`
`167`	`170`	`super.renderGridCellContents(ctx, out);`
`168`	`171`	`}`