Skip to content

Commit f188499

Browse files
committed
Refactor app.tsx and dev.tsx
1 parent 5942e57 commit f188499

File tree

8 files changed

+30
-39
lines changed

8 files changed

+30
-39
lines changed
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
import React from 'react';
2-
import ReactDOM from 'react-dom';
3-
41
import View from './Browser';
2+
import { createRoot } from 'react-dom/client';
3+
import React from 'react';
54

65
// Need to wait for container element to be available in labkey wrapper before render
76
window.addEventListener('DOMContentLoaded', (event) => {
8-
ReactDOM.render(<View />, document.getElementById('app'))
7+
createRoot(document.getElementById('app')).render(<View />)
98
});
Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
1-
import React from 'react';
2-
import ReactDOM from 'react-dom';
3-
41
import View from './Browser';
2+
import { createRoot } from 'react-dom/client';
3+
import React from 'react';
54

6-
const render = () => {
7-
ReactDOM.render(<View />, document.getElementById('app'));
8-
};
9-
10-
render();
5+
// Need to wait for container element to be available in labkey wrapper before render
6+
window.addEventListener('DOMContentLoaded', (event) => {
7+
createRoot(document.getElementById('app')).render(<View />)
8+
}, true);
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
import React from 'react';
2-
import ReactDOM from 'react-dom';
2+
import { createRoot } from 'react-dom/client';
33
import { App } from '@labkey/api';
44

55
import StandaloneSearch from '../StandaloneSearch';
66

77
App.registerApp<any>('jbrowseSearchWebpart', (target: string, sessionId: string) => {
8-
ReactDOM.render(
9-
<StandaloneSearch sessionId={sessionId} />
10-
, document.getElementById(target));
11-
});
8+
createRoot(document.getElementById(target)).render(<StandaloneSearch sessionId={sessionId} />)
9+
});
Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
import React from 'react';
2-
import ReactDOM from 'react-dom';
2+
import { createRoot } from 'react-dom/client';
33
import { App } from '@labkey/api';
44

55
import StandaloneSearch from '../StandaloneSearch';
66

7-
const render = (target: string, sessionId: string) => {
8-
ReactDOM.render(<StandaloneSearch sessionId={sessionId} />, document.getElementById(target));
9-
};
10-
11-
App.registerApp<any>('jbrowseSearchWebpart', render, true /* hot */);
7+
App.registerApp<any>('jbrowseSearchWebpart', (target: string, sessionId: string) => {
8+
createRoot(document.getElementById(target)).render(<StandaloneSearch sessionId={sessionId} />)
9+
}, true);
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import React from 'react';
2-
import ReactDOM from 'react-dom';
32

43
import VariantTable from './VariantTable';
4+
import { createRoot } from 'react-dom/client';
55

66
// Need to wait for container element to be available in labkey wrapper before render
77
window.addEventListener('DOMContentLoaded', (event) => {
8-
ReactDOM.render(<VariantTable/>, document.getElementById('app'))
8+
createRoot(document.getElementById('app')).render(<VariantTable />)
99
});
Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import React from 'react';
2-
import ReactDOM from 'react-dom';
32

43
import VariantTable from './VariantTable';
4+
import { createRoot } from 'react-dom/client';
55

6-
const render = () => {
7-
ReactDOM.render(<VariantTable />, document.getElementById('app'));
8-
};
9-
10-
render();
6+
// Need to wait for container element to be available in labkey wrapper before render
7+
window.addEventListener('DOMContentLoaded', (event) => {
8+
createRoot(document.getElementById('app')).render(<VariantTable />)
9+
}, true);
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import React from 'react';
2-
import ReactDOM from 'react-dom';
32

43
import VariantTable from './VariantTable';
4+
import { createRoot } from 'react-dom/client';
55

66
// Need to wait for container element to be available in labkey wrapper before render
77
window.addEventListener('DOMContentLoaded', (event) => {
8-
ReactDOM.render(<VariantTable/>, document.getElementById('app'))
8+
createRoot(document.getElementById('app')).render(<VariantTable />)
99
});
Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import React from 'react';
2-
import ReactDOM from 'react-dom';
32

43
import VariantTable from './VariantTable';
4+
import { createRoot } from 'react-dom/client';
55

6-
const render = () => {
7-
ReactDOM.render(<VariantTable />, document.getElementById('app'));
8-
};
9-
10-
render();
6+
// Need to wait for container element to be available in labkey wrapper before render
7+
window.addEventListener('DOMContentLoaded', (event) => {
8+
createRoot(document.getElementById('app')).render(<VariantTable />)
9+
}, true);

0 commit comments

Comments
 (0)