Skip to content

Commit ede3b1e

Browse files
committed
Bugfix to RestoreSraDataHandler for new SRA datasets
1 parent 9a6abc8 commit ede3b1e

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

SequenceAnalysis/src/org/labkey/sequenceanalysis/query/SequenceTriggerHelper.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.labkey.sequenceanalysis.SequenceAnalysisSchema;
3737
import org.labkey.sequenceanalysis.SequenceAnalysisServiceImpl;
3838
import org.labkey.sequenceanalysis.SequenceReadsetImpl;
39+
import org.labkey.sequenceanalysis.pipeline.ReadsetImportJob;
3940
import org.labkey.vfs.FileLike;
4041

4142
import java.io.File;
@@ -302,7 +303,8 @@ public void createReaddataForSra(int readsetId, String sraAccessions)
302303
}
303304

304305
String folderName = "SequenceImport_RS" + rs.getRowId() + "_" + FileUtil.getTimestamp();
305-
FileLike outDir = AssayFileWriter.findUniqueFileName(folderName, pr.getRootFileLike());
306+
FileLike sequenceImport = FileUtil.appendPath(pr.getRootFileLike(), Path.parse(ReadsetImportJob.NAME));
307+
FileLike outDir = AssayFileWriter.findUniqueFileName(folderName, sequenceImport);
306308

307309
FileLike expectedFile1 = FileUtil.appendPath(outDir, Path.parse(token + "_1.fastq.gz"));
308310
ExpData exp1 = ExperimentService.get().createData(c, new DataType("Data"));

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/RestoreSraDataHandler.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,13 @@ public void init(PipelineJob job, SequenceAnalysisJobSupport support, List<Reads
158158
throw new PipelineJobException("Missing Expdata: " + rd.getFileId1());
159159
}
160160

161-
if (!f1.getFile().exists() && !f1.getFile().getParentFile().exists())
161+
if (!f1.getFile().exists())
162162
{
163+
if (f1.getFile().getParentFile().exists())
164+
{
165+
job.getLogger().warn("Parent file unexpectedly exists: " + f1.getFile().getParentFile().getPath());
166+
}
167+
163168
f1.setDataFileURI(new File(outputDir, accession + "_1.fastq.gz").toURI());
164169
f1.save(job.getUser());
165170
job.getLogger().debug("Updating filepath: " + f1.getFile().getPath());

0 commit comments

Comments
 (0)