Skip to content

Commit d59c043

Browse files
committed
Merge remote-tracking branch 'origin/develop' into fb_gradle_9.0.0
2 parents 40105dd + a7a9bc2 commit d59c043

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

SequenceAnalysis/resources/web/SequenceAnalysis/panel/SequenceImportPanel.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -603,8 +603,6 @@ Ext4.define('SequenceAnalysis.panel.SequenceImportPanel', {
603603
this.fileNameStore.each(function(f){
604604
msg += '[' + f.get('fileName') + ']\n';
605605
}, this);
606-
607-
LDK.Utils.logError(msg);
608606
}
609607

610608
return errorMsgs;
@@ -630,7 +628,6 @@ Ext4.define('SequenceAnalysis.panel.SequenceImportPanel', {
630628
msg += '[' + f.get('fileName') + ']\n';
631629
}, this);
632630

633-
LDK.Utils.logError(msg);
634631
errorMsgs.push('Possible error: Encountered reverse reads prior to forward reads for ' + setId + ', which can indicate files are out of alphabetical order, one file from a pair is missing, or a problem parsing the filenames. Please check over the file groups carefully.');
635632

636633
var m = Ext4.create('SequenceAnalysis.model.ReadsetDataModel', {});

SequenceAnalysis/src/org/labkey/sequenceanalysis/SequenceAnalysisModule.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -494,10 +494,7 @@ public Set<ExperimentRunType> getExperimentRunTypes(@Nullable Container containe
494494

495495
ExperimentService.get().registerExperimentDataHandler(new HtmlExpDataHandler());
496496

497-
SearchService ss = SearchService.get();
498-
499-
if (null != ss)
500-
ss.addDocumentParser(new SequenceNoOpDocumentParser());
497+
SearchService.get().addDocumentParser(new SequenceNoOpDocumentParser());
501498
}
502499

503500
@Override

singlecell/resources/web/singlecell/panel/PoolImportPanel.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ Ext4.define('SingleCell.panel.PoolImportPanel', {
149149
allowRowSpan: true
150150
},{
151151
name: 'kitType',
152-
labels: ['Kit Type', 'V1.1/V2/HT', 'V1.1/HT', 'HT/V1.1/V2'],
152+
labels: ['Kit Type', 'V1.1/V2/HT', 'V1.1/HT', 'HT/V1.1/V2', 'V2/HT'],
153153
transform: 'kitType'
154154
}],
155155

@@ -819,7 +819,7 @@ Ext4.define('SingleCell.panel.PoolImportPanel', {
819819
if (row[kitCol.dataIdx].toUpperCase() === 'V1.1') {
820820
data.dualIndex10x = false;
821821
}
822-
else if (row[kitCol.dataIdx].toUpperCase() === 'V2' || row[kitCol.dataIdx].toUpperCase() === 'HT') {
822+
else if (row[kitCol.dataIdx].toUpperCase() === 'V2' || row[kitCol.dataIdx].toUpperCase() === 'HT' || row[kitCol.dataIdx].toUpperCase() === 'V3') {
823823
data.dualIndex10x = true;
824824
}
825825
else {
@@ -828,7 +828,7 @@ Ext4.define('SingleCell.panel.PoolImportPanel', {
828828
}
829829

830830
Ext4.Array.forEach(colArray, function(col, colIdx){
831-
var cell = Ext4.isDefined(col.dataIdx) ? Ext4.String.trim(row[col.dataIdx]) : '';
831+
var cell = Ext4.isDefined(col.dataIdx) && row[col.dataIdx] ? Ext4.String.trim(row[col.dataIdx]) : '';
832832
if (cell){
833833
if (col.transform && this.transforms[col.transform]){
834834
cell = this.transforms[col.transform](cell, this, data);

0 commit comments

Comments
 (0)