Improve test

bbimber · bbimber · commit bb20417946bf · 2025-04-04T13:06:48.000-07:00
diff --git a/jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTest.java b/jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTest.java
@@ -496,10 +496,10 @@ private void testGenotypeFrequencies()
         assertElementPresent(Locator.tagWithText("td", "3041"));
         assertElementPresent(Locator.tagWithText("span", "Genotype Frequency (2329)"));
         assertElementPresent(Locator.tagWithText("a", "Click here to view sample-level genotypes"));
-        while(isTextPresent("Loading")){
+        while (isTextPresent("Loading")){
             sleep(10);
         }
-        assertElementPresent(Locator.tagWithAttributeContaining("div","id","reactgooglegraph"));
+        waitForElement(Locator.tagWithAttributeContaining("div","id","reactgooglegraph"));
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -496,10 +496,10 @@ private void testGenotypeFrequencies()`
`496`	`496`	`assertElementPresent(Locator.tagWithText("td", "3041"));`
`497`	`497`	`assertElementPresent(Locator.tagWithText("span", "Genotype Frequency (2329)"));`
`498`	`498`	`assertElementPresent(Locator.tagWithText("a", "Click here to view sample-level genotypes"));`
`499`		`- while(isTextPresent("Loading")){`
	`499`	`+ while (isTextPresent("Loading")){`
`500`	`500`	`sleep(10);`
`501`	`501`	`}`
`502`		`- assertElementPresent(Locator.tagWithAttributeContaining("div","id","reactgooglegraph"));`
	`502`	`+ waitForElement(Locator.tagWithAttributeContaining("div","id","reactgooglegraph"));`
`503`	`503`	`}`
`504`	`504`
`505`	`505`	`@Override`