Skip to content

Commit a5a396f

Browse files
authored
Merge pull request #334 from LabKey/fb_merge_24.11_to_develop
Merge discvr-24.11 to develop
2 parents d8a793c + 01b4f8b commit a5a396f

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/alignment/SVTyperStep.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ else if (!svVcf.exists())
113113
jsonArgs.add("-l");
114114
jsonArgs.add(coverageJson.getPath());
115115

116+
jsonArgs.add("--verbose");
117+
116118
File doneFile = new File(ctx.getWorkingDirectory(), "json.done");
117119
ctx.getFileManager().addIntermediateFile(doneFile);
118120
if (doneFile.exists())
@@ -151,6 +153,8 @@ else if (!svVcf.exists())
151153
svtyperArgs.add("-l");
152154
svtyperArgs.add(coverageJson.getPath());
153155

156+
svtyperArgs.add("--verbose");
157+
154158
if (threads != null)
155159
{
156160
svtyperArgs.add("--core");

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/variant/PlinkPcaStep.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,17 @@ private void runBatch(File inputVCF, File outputDirectory, VariantProcessingStep
228228
throw new PipelineJobException("Unable to find expected file: " + outputFile);
229229
}
230230

231+
String description = null;
232+
if (kingCutoff != null)
233+
{
234+
long includedIds = SequencePipelineService.get().getLineCount(new File(outputFile.getParentFile(), "plink.king.cutoff.in.id"));
235+
long excludedIds = SequencePipelineService.get().getLineCount(new File(outputFile.getParentFile(), "plink.king.cutoff.out.id"));
236+
237+
description = String.format("KING cutoff: %f, included IDs: %d, excluded IDs: %d", kingCutoff, includedIds, excludedIds);
238+
}
239+
231240
output.addOutput(outputFile, "PLink PCA");
232-
output.addSequenceOutput(outputFile, "PLink PCA for: " + inputVCF.getName() + (setName == null ? "" : ", for: " + setName), "PLink PCA", null, null, genome.getGenomeId(), null);
241+
output.addSequenceOutput(outputFile, "PLink PCA for: " + inputVCF.getName() + (setName == null ? "" : ", for: " + setName), "PLink PCA", null, null, genome.getGenomeId(), description);
233242
}
234243

235244
@Override

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/variant/SnpEffWrapper.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.labkey.api.pipeline.PipelineJobService;
99
import org.labkey.api.sequenceanalysis.SequenceAnalysisService;
1010
import org.labkey.api.sequenceanalysis.pipeline.ReferenceGenome;
11+
import org.labkey.api.sequenceanalysis.pipeline.ReferenceGenomeManager;
1112
import org.labkey.api.sequenceanalysis.pipeline.SequencePipelineService;
1213
import org.labkey.api.sequenceanalysis.run.AbstractCommandWrapper;
1314
import org.labkey.api.util.FileUtil;
@@ -159,6 +160,8 @@ else if ("gbk".equalsIgnoreCase(ext))
159160
//params.add(basename);
160161

161162
execute(params);
163+
164+
ReferenceGenomeManager.get().markGenomeModified(genome, getLogger());
162165
}
163166

164167

singlecell/api-src/org/labkey/api/singlecell/CellHashingService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public static CellHashingService.CellHashingParameters createFromStep(SequenceOu
132132
ret.callerDisagreementThreshold = step.getProvider().getParameterByName("callerDisagreementThreshold").extractValue(ctx.getJob(), step.getProvider(), step.getStepIdx(), Double.class, null);
133133
ret.doTSNE = step.getProvider().getParameterByName("doTSNE").extractValue(ctx.getJob(), step.getProvider(), step.getStepIdx(), Boolean.class, false);
134134
ret.doNotAllowResume = step.getProvider().getParameterByName("doNotAllowResume").extractValue(ctx.getJob(), step.getProvider(), step.getStepIdx(), Boolean.class, false);
135-
ret.retainRawCountFile = step.getProvider().getParameterByName("retainRawCountFile").extractValue(ctx.getJob(), step.getProvider(), step.getStepIdx(), Boolean.class, true);
135+
ret.retainRawCountFile = step.getProvider().getParameterByName("retainRawCountFile").extractValue(ctx.getJob(), step.getProvider(), step.getStepIdx(), Boolean.class, false);
136136
ret.failIfUnexpectedHtosFound = step.getProvider().getParameterByName("failIfUnexpectedHtosFound").extractValue(ctx.getJob(), step.getProvider(), step.getStepIdx(), Boolean.class, true);
137137
ret.htoReadset = htoReadset;
138138
ret.parentReadset = parentReadset;
@@ -177,7 +177,7 @@ public static CellHashingParameters createFromJson(BARCODE_TYPE type, File webse
177177
ret.callerDisagreementThreshold = params.get("callerDisagreementThreshold") == null ? null : params.getDouble("callerDisagreementThreshold");
178178
ret.doTSNE = params.optBoolean("doTSNE", false);
179179
ret.doNotAllowResume = params.optBoolean("doNotAllowResume", false);
180-
ret.retainRawCountFile = params.optBoolean("retainRawCountFile", true);
180+
ret.retainRawCountFile = params.optBoolean("retainRawCountFile", false);
181181
ret.failIfUnexpectedHtosFound = params.optBoolean("failIfUnexpectedHtosFound", true);
182182
ret.htoReadset = htoReadset;
183183
ret.parentReadset = parentReadset;

0 commit comments

Comments
 (0)