Skip to content

Commit a58aa88

Browse files
committed
Omit writing to 10x barcodes
1 parent 544c4ea commit a58aa88

File tree

4 files changed

+1
-28
lines changed

4 files changed

+1
-28
lines changed

singlecell/src/org/labkey/singlecell/run/AbstractCellRangerDependentStep.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ protected File runCellRanger(AlignmentOutputImpl output, Readset rs, List<File>
8888
}
8989
}
9090

91-
NimbleHelper.write10xBarcodes(localBam, getWrapper().getLogger(), rs, referenceGenome, output);
92-
9391
return localBam;
9492
}
9593

singlecell/src/org/labkey/singlecell/run/CellRangerGexCountStep.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -396,15 +396,6 @@ public AlignmentOutput performAlignment(Readset rs, List<File> inputFastqs1, @Nu
396396
outdir = new File(outdir, "outs");
397397

398398
File bam = new File(outdir, "possorted_genome_bam.bam");
399-
if (bam.exists())
400-
{
401-
NimbleHelper.write10xBarcodes(bam, getWrapper().getLogger(), rs, referenceGenome, output);
402-
}
403-
else
404-
{
405-
getPipelineCtx().getLogger().info("BAM file does not exist, cannot write 10x barcodes: " + bam.getPath());
406-
}
407-
408399
if (!shouldDiscardBam())
409400
{
410401
if (!bam.exists())

singlecell/src/org/labkey/singlecell/run/NimbleAlignmentStep.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ public class NimbleAlignmentStep extends AbstractCellRangerDependentStep
4141
public static final String MAX_HITS_TO_REPORT = "maxHitsToReport";
4242
public static final String STRANDEDNESS = "strandedness";
4343
public static final String REQUIRE_CACHED_BARCODES = "requireCachedBarcodes";
44-
public static final String WRITE_10X_BARCODES = "write10xBarcodes";
4544

4645
public NimbleAlignmentStep(AlignmentStepProvider<?> provider, PipelineContext ctx, CellRangerWrapper wrapper)
4746
{
@@ -77,10 +76,7 @@ public static List<ToolParameterDescriptor> getToolParameters()
7776
}}, 4),
7877
ToolParameterDescriptor.create(REQUIRE_CACHED_BARCODES, "Fail Unless Cached Barcodes Present", "If checked, the pipeline will expect a previously computed map of cellbarcodes and UMIs to be computed. Under default conditions, if this is missing, cellranger will be re-run. This flag can be helpful to avoid that computation if you expect the barcode file to exist.", "checkbox", new JSONObject(){{
7978

80-
}}, false),
81-
ToolParameterDescriptor.create(WRITE_10X_BARCODES, "Write 10x Barcodes To File", "If checked, the pipeline will save the 10x barcodes from the BAM to a TSV. This facilitates future analyses.", "checkbox", new JSONObject(){{
82-
83-
}}, true)
79+
}}, false)
8480
);
8581
}
8682

singlecell/src/org/labkey/singlecell/run/NimbleAnalysis.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
import java.util.LinkedHashSet;
1919
import java.util.List;
2020

21-
import static org.labkey.singlecell.run.NimbleAlignmentStep.WRITE_10X_BARCODES;
22-
2321
public class NimbleAnalysis extends AbstractPipelineStep implements AnalysisStep
2422
{
2523
public NimbleAnalysis(PipelineStepProvider<?> provider, PipelineContext ctx)
@@ -60,16 +58,6 @@ public Output performAnalysisPerSampleRemote(Readset rs, File inputBam, Referenc
6058
NimbleHelper helper = new NimbleHelper(getPipelineCtx(), getProvider(), getStepIdx());
6159
helper.doNimbleAlign(inputBam, output, rs, FileUtil.getBaseName(inputBam));
6260

63-
boolean write10xBarcodes = getProvider().getParameterByName(WRITE_10X_BARCODES).extractValue(getPipelineCtx().getJob(), getProvider(), getStepIdx(), Boolean.class, true);
64-
if (write10xBarcodes)
65-
{
66-
NimbleHelper.write10xBarcodes(inputBam, getPipelineCtx().getLogger(), rs, referenceGenome, output);
67-
}
68-
else
69-
{
70-
getPipelineCtx().getLogger().info("10x barcodes will not be saved to TSV");
71-
}
72-
7361
return output;
7462
}
7563

0 commit comments

Comments
 (0)