Skip to content

Commit 4818e5a

Browse files
committed
Greater visibility to submitting jobs to source container when applying template
1 parent 53356c8 commit 4818e5a

File tree

4 files changed

+24
-12
lines changed

4 files changed

+24
-12
lines changed

SequenceAnalysis/resources/web/SequenceAnalysis/panel/BaseSequencePanel.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,10 @@ Ext4.define('SequenceAnalysis.panel.BaseSequencePanel', {
269269
Ext4.defer(field.focus, 200, field);
270270
}
271271
}
272+
},{
273+
xtype: 'checkbox',
274+
itemId: 'useReadsetContainer',
275+
fieldLabel: 'Submit Jobs to Same Folder/Workbook as Readset'
272276
}]
273277
}],
274278
buttons: [{
@@ -294,6 +298,12 @@ Ext4.define('SequenceAnalysis.panel.BaseSequencePanel', {
294298
json = Ext4.decode(json);
295299
}
296300

301+
var useReadsetContainer = win.down('#useReadsetContainer').getValue();
302+
if (!useReadsetContainer) {
303+
delete json.useOutputFileContainer;
304+
delete json.submitJobToReadsetContainer;
305+
}
306+
297307
win.sequencePanel.applySavedValues(json);
298308
win.close();
299309
}
@@ -354,5 +364,15 @@ Ext4.define('SequenceAnalysis.panel.BaseSequencePanel', {
354364
Ext4.Array.forEach(sections, function(s){
355365
s.applySavedValues(values);
356366
}, this);
367+
368+
// For top-level properties:
369+
Ext4.Array.forEach(['submissionType', 'useOutputFileContainer', 'submitJobToReadsetContainer'], function(val) {
370+
if (values[val]) {
371+
var field = this.down('[name="' + val + '"]');
372+
if (field) {
373+
field.setValue(values[val]);
374+
}
375+
}
376+
}, this);
357377
}
358378
});

SequenceAnalysis/resources/web/SequenceAnalysis/panel/SequenceAnalysisPanel.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,9 +318,8 @@ Ext4.define('SequenceAnalysis.panel.SequenceAnalysisPanel', {
318318
checked: false,
319319
xtype: 'checkbox'
320320
}, this.getSaveTemplateCfg(),{
321-
fieldLabel: 'Submit Jobs To Same Container As Readset?',
321+
fieldLabel: 'Submit Jobs To Same Folder/Workbook As Readset?',
322322
helpPopup: 'If checked, each alignment job will be submitted to the container/workbook of the parent readset, rather than this container',
323-
hidden: !LABKEY.Security.currentUser.isAdmin,
324323
name: 'submitJobToReadsetContainer',
325324
inputValue: true,
326325
uncheckedValue: false,

singlecell/resources/views/singleCellDataManagement.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@
3939
},{
4040
name: 'Readsets Assigned to Run Lacking Data',
4141
url: LABKEY.ActionURL.buildURL('query', 'executeQuery.view', null, {schemaName: 'sequenceanalysis', queryName: 'sequence_readsets', 'query.viewName': 'Assigned to Run Lacking Data'})
42+
},{
43+
name: 'Analyses In Novogene-Related Workbook',
44+
url: LABKEY.ActionURL.buildURL('query', 'executeQuery.view', null, {schemaName: 'sequenceanalysis', queryName: 'sequence_analyses', 'query.container/title~containsoneof': 'Novogene;shipment'})
4245
}]
4346
},{
4447
header: 'Data Archival',

singlecell/resources/web/singlecell/panel/SingleCellProcessingPanel.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -329,15 +329,5 @@ Ext4.define('SingleCell.panel.SingleCellProcessingPanel', {
329329

330330
errors = Ext4.unique(errors);
331331
return errors;
332-
},
333-
334-
applySavedValues: function(values){
335-
this.callOverridden(arguments);
336-
337-
Ext4.Array.forEach(['submissionType', 'useOutputFileContainer'], function(val) {
338-
if (values[val]) {
339-
this.down('[name="' + val + '"]').setValue(values[val]);
340-
}
341-
}, this);
342332
}
343333
});

0 commit comments

Comments
 (0)