Finish renderGridCellContents migration

Author: bbimber

SequenceAnalysis/src/org/labkey/sequenceanalysis/query/DownloadSequenceDisplayColumnFactory.java

@@ -12,8 +12,6 @@
 import org.labkey.api.view.template.ClientDependency;
 import org.labkey.api.writer.HtmlWriter;
 
-import java.io.IOException;
-import java.io.Writer;
 import java.util.Collections;
 import java.util.LinkedHashSet;
 import java.util.Map;
@@ -39,12 +37,12 @@ public DisplayColumn createRenderer(ColumnInfo colInfo)
             private boolean _handlerRegistered = false;
 
             @Override
-            public void renderGridCellContents(RenderContext ctx, Writer oldWriter, HtmlWriter out) throws IOException
+            public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
             {
-                Object val = ctx.get(FieldKey.fromString(getBoundColumn().getFieldKey().getParent(), "rowId"));
-                oldWriter.write(PageFlowUtil.link("Download Sequence").attributes(Map.of(
+                Integer val = ctx.get(FieldKey.fromString(getBoundColumn().getFieldKey().getParent(), "rowId"), Integer.class);
+                out.write(PageFlowUtil.link("Download Sequence").attributes(Map.of(
                     "data-rowid", val.toString()
-                )).addClass("sdc-row").toString());
+                )).addClass("sdc-row"));
 
                 if (!_handlerRegistered)
                 {

SequenceAnalysis/src/org/labkey/sequenceanalysis/query/GenbankDisplayColumnFactory.java

@@ -24,26 +24,25 @@ public GenbankDisplayColumnFactory()
     @Override
     public DisplayColumn createRenderer(ColumnInfo colInfo)
     {
-        DataColumn ret = new DataColumn(colInfo)
+        return new DataColumn(colInfo)
         {
             @Override
-            public void renderGridCellContents(RenderContext ctx, Writer oldWriter, HtmlWriter out) throws IOException
+            public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
             {
-                Object val = ctx.get(getBoundColumn().getFieldKey());
+                String val = ctx.get(getBoundColumn().getFieldKey(), String.class);
                 if (val != null)
                 {
-                    String[] vals = String.valueOf(val).replaceAll("\\s+", "").split(";|,");
+                    String[] vals = val.replaceAll("\\s+", "").split("[;,]");
                     String delim = "";
                     for (String v : vals)
                     {
-                        oldWriter.write(delim + "<a href=" + getFormattedURL(v) + ">" + PageFlowUtil.encode(v) + "</a>");
+                        out.write(PageFlowUtil.link(v).href(getFormattedURL(v)));
+                        out.write(delim);
                         delim = "; ";
                     }
                 }
             }
         };
-
-        return ret;
     }
 
     protected String getFormattedURL(String v)