Cache unmodifiableMaps

bbimber · bbimber · commit 3ce4da84810d · 2025-06-30T07:47:54.000-07:00
diff --git a/jbrowse/src/org/labkey/jbrowse/JBrowseFieldUtils.java b/jbrowse/src/org/labkey/jbrowse/JBrowseFieldUtils.java
@@ -16,6 +16,7 @@
 import org.labkey.jbrowse.model.JsonFile;
 
 import java.io.File;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.Map;
@@ -80,7 +81,7 @@ public static Map<String, JBrowseFieldDescriptor> getIndexedFields(JsonFile json
                 fd.lock();
             }
 
-            _cache.put(key, ret);
+            _cache.put(key, Collections.unmodifiableMap(ret));
         }
 
         // Clone cached results:
@@ -150,7 +151,7 @@ public static Map<String, JBrowseFieldDescriptor> getGenotypeDependentFields(@Nu
                 fd.lock();
             }
 
-            _cache.put(key, ret);
+            _cache.put(key, Collections.unmodifiableMap(ret));
         }
 
         // Clone cached results:

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`	`import org.labkey.jbrowse.model.JsonFile;`
`17`	`17`
`18`	`18`	`import java.io.File;`
	`19`	`+import java.util.Collections;`
`19`	`20`	`import java.util.HashMap;`
`20`	`21`	`import java.util.LinkedHashMap;`
`21`	`22`	`import java.util.Map;`
`@@ -80,7 +81,7 @@ public static Map<String, JBrowseFieldDescriptor> getIndexedFields(JsonFile json`
`80`	`81`	`fd.lock();`
`81`	`82`	`}`
`82`	`83`
`83`		`- _cache.put(key, ret);`
	`84`	`+ _cache.put(key, Collections.unmodifiableMap(ret));`
`84`	`85`	`}`
`85`	`86`
`86`	`87`	`// Clone cached results:`
`@@ -150,7 +151,7 @@ public static Map<String, JBrowseFieldDescriptor> getGenotypeDependentFields(@Nu`
`150`	`151`	`fd.lock();`
`151`	`152`	`}`
`152`	`153`
`153`		`- _cache.put(key, ret);`
	`154`	`+ _cache.put(key, Collections.unmodifiableMap(ret));`
`154`	`155`	`}`
`155`	`156`
`156`	`157`	`// Clone cached results:`