Skip to content

Commit 391f7f7

Browse files
authored
Refactor JBrowseTest to streamline variant handling
Removed redundant variant waits and adjusted click action.
1 parent 2cc0240 commit 391f7f7

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTest.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -438,11 +438,6 @@ private void testSessionCardDisplay()
438438
beginAt("/" + getProjectName() + "/jbrowse-jbrowse.view?session=mgap&location=1:8328..8842");
439439
waitForJBrowseToLoad();
440440

441-
// This will wait for them, allowing the full browser to lod:
442-
getVariantWithinTrack("mgap_hg38", "SNV C -> T");
443-
getVariantWithinTrack("mgap_hg38", "SNV G -> C");
444-
445-
446441
Actions actions = new Actions(getDriver());
447442
WebElement toClick = getDriver().findElements(getVariantWithinTrack("mgap_hg38", "SNV A -> G")).stream().filter(WebElement::isDisplayed).collect(JBrowseTestHelper.toSingleton());
448443
actions.click(toClick).perform();
@@ -456,9 +451,12 @@ private void testTitleMapping()
456451
beginAt("/" + getProjectName() + "/jbrowse-jbrowse.view?session=mgap&location=1:104..275");
457452
waitForJBrowseToLoad();
458453

454+
// This will wait for them, allowing the full browser to lod:
455+
getVariantWithinTrack("mgap_hg38", "SNV C -> T");
456+
getVariantWithinTrack("mgap_hg38", "SNV G -> C");
457+
459458
Actions actions = new Actions(getDriver());
460459
WebElement toClick = getDriver().findElements(getVariantWithinTrack("mgap_hg38", "SNV T -> C")).stream().filter(WebElement::isDisplayed).collect(JBrowseTestHelper.toSingleton()); // 1:137..137
461-
WebDriverWrapper.sleep(100); // This allows a short window for rendering prior to clicking variants
462460
actions.click().perform();
463461

464462
waitForElement(Locator.tagWithText("div", "1:137"));

0 commit comments

Comments
 (0)