Improve element wait handling in JBrowseTestHelper

bbimber · web-flow · commit 057bebe5891e · 2025-10-27T08:54:21.000-07:00
Replaced sleep with explicit wait for element to be clickable.
diff --git a/jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTestHelper.java b/jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTestHelper.java
@@ -16,6 +16,7 @@
 import org.openqa.selenium.Point;
 import org.openqa.selenium.StaleElementReferenceException;
 import org.openqa.selenium.WebElement;
+import org.openqa.selenium.support.ui.ExpectedConditions;
 
 import java.io.File;
 import java.util.stream.Collector;
@@ -149,7 +150,8 @@ public static By getVariantWithinTrack(BaseWebDriverTest test, String trackId, S
         }
 
         test.waitForElement(l);
-        WebDriverWrapper.sleep(100); // This allows a short window for rendering prior to clicking variants
+        WebElement el = test.waitForElement(l);
+        test.shortWait().until(ExpectedConditions.elementToBeClickable(el));
 
         return By.xpath(l.toXpath());
     }

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`	`import org.openqa.selenium.Point;`
`17`	`17`	`import org.openqa.selenium.StaleElementReferenceException;`
`18`	`18`	`import org.openqa.selenium.WebElement;`
	`19`	`+import org.openqa.selenium.support.ui.ExpectedConditions;`
`19`	`20`
`20`	`21`	`import java.io.File;`
`21`	`22`	`import java.util.stream.Collector;`
`@@ -149,7 +150,8 @@ public static By getVariantWithinTrack(BaseWebDriverTest test, String trackId, S`
`149`	`150`	`}`
`150`	`151`
`151`	`152`	`test.waitForElement(l);`
`152`		`- WebDriverWrapper.sleep(100); // This allows a short window for rendering prior to clicking variants`
	`153`	`+ WebElement el = test.waitForElement(l);`
	`154`	`+ test.shortWait().until(ExpectedConditions.elementToBeClickable(el));`
`153`	`155`
`154`	`156`	`return By.xpath(l.toXpath());`
`155`	`157`	`}`