Skip to content

Commit 876b10f

Browse files
authored
Simplify and expand use of LinkBuilder factory methods (#251)
1 parent c5e86ee commit 876b10f

12 files changed

+36
-26
lines changed

mGAP/src/org/labkey/mgap/query/OMIMDisplayColumnFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.labkey.api.data.RenderContext;
99
import org.labkey.api.query.FieldKey;
1010
import org.labkey.api.util.HtmlString;
11+
import org.labkey.api.util.LinkBuilder;
1112
import org.labkey.api.util.PageFlowUtil;
1213
import org.labkey.api.writer.HtmlWriter;
1314

@@ -59,7 +60,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
5960
}
6061

6162
out.write(delim);
62-
out.write(PageFlowUtil.link(text).href("https://www.omim.org/entry/" + id).target("_blank").clearClasses());
63+
out.write(LinkBuilder.simpleLink(text, "https://www.omim.org/entry/" + id).target("_blank"));
6364
delim = HtmlString.BR;
6465
}
6566
}

mGAP/src/org/labkey/mgap/query/OMIMPhenotypeDisplayColumnFactory.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.labkey.api.data.RenderContext;
99
import org.labkey.api.query.FieldKey;
1010
import org.labkey.api.util.HtmlString;
11+
import org.labkey.api.util.LinkBuilder;
1112
import org.labkey.api.util.PageFlowUtil;
1213
import org.labkey.api.writer.HtmlWriter;
1314

@@ -68,11 +69,11 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
6869
out.write(delim);
6970
if (elements.length > 1)
7071
{
71-
out.write(PageFlowUtil.link(elements[0]).target("_blank").href("https://www.omim.org/entry/" + elements[1]).clearClasses());
72+
out.write(LinkBuilder.simpleLink(elements[0], "https://www.omim.org/entry/" + elements[1]).target("_blank"));
7273
}
7374
else
7475
{
75-
out.write(PageFlowUtil.link(elements[0]).clearClasses());
76+
out.write(LinkBuilder.simpleLink(elements[0]));
7677
}
7778

7879
delim = HtmlString.BR;

mGAP/src/org/labkey/mgap/query/OverlappingGenesDisplayColumnFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.labkey.api.data.RenderContext;
99
import org.labkey.api.query.FieldKey;
1010
import org.labkey.api.util.HtmlString;
11+
import org.labkey.api.util.LinkBuilder;
1112
import org.labkey.api.util.PageFlowUtil;
1213
import org.labkey.api.writer.HtmlWriter;
1314

@@ -66,7 +67,7 @@ else if (geneName.startsWith("ENSMMUE"))
6667
}
6768

6869
out.write(delim);
69-
out.write(PageFlowUtil.link(geneName).href(url).target("_blank").clearClasses());
70+
out.write(LinkBuilder.simpleLink(geneName, url).target("_blank"));
7071
delim = HtmlString.BR;
7172
}
7273
}

mGAP/src/org/labkey/mgap/query/PhenotypeVariantLinkDisplayColumnFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import org.labkey.api.data.RenderContext;
99
import org.labkey.api.query.DetailsURL;
1010
import org.labkey.api.query.FieldKey;
11-
import org.labkey.api.util.PageFlowUtil;
11+
import org.labkey.api.util.LinkBuilder;
1212
import org.labkey.api.writer.HtmlWriter;
1313

1414
import java.util.List;
@@ -52,7 +52,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
5252
if (releaseId != null && omim != null)
5353
{
5454
DetailsURL url = DetailsURL.fromString("/mgap/variantList.view?release=" + releaseId + "&query.omim_phenotype~contains=" + omim, ContainerManager.getForId(containerId));
55-
out.write(PageFlowUtil.link("View Variants").href(url.getActionURL()).addClass("labkey-text-link"));
55+
out.write(LinkBuilder.labkeyLink("View Variants", url.getActionURL()));
5656
}
5757
}
5858
};

mGAP/src/org/labkey/mgap/query/SourceDisplayColumnFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import org.labkey.api.data.DisplayColumnFactory;
1010
import org.labkey.api.data.RenderContext;
1111
import org.labkey.api.query.FieldKey;
12+
import org.labkey.api.util.LinkBuilder;
1213
import org.labkey.api.util.PageFlowUtil;
1314
import org.labkey.api.writer.HtmlWriter;
1415

@@ -66,7 +67,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
6667
}
6768
else
6869
{
69-
out.write(PageFlowUtil.link(val).href(url).clearClasses());
70+
out.write(LinkBuilder.simpleLink(val, url));
7071
}
7172
}
7273

mGAP/src/org/labkey/mgap/query/TracksPerReleaseGenomeBrowserDisplayColumnFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.labkey.api.data.DisplayColumn;
66
import org.labkey.api.data.RenderContext;
77
import org.labkey.api.query.DetailsURL;
8+
import org.labkey.api.util.LinkBuilder;
89
import org.labkey.api.util.PageFlowUtil;
910
import org.labkey.api.writer.HtmlWriter;
1011

@@ -28,7 +29,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
2829
if (jbrowseId != null && trackName != null)
2930
{
3031
DetailsURL url = DetailsURL.fromString("/mgap/genomeBrowser.view?database=" + jbrowseId + "&activeTracks=" + trackName, ContainerManager.getForId(containerId));
31-
out.write(PageFlowUtil.link("View In Genome Browser").addClass("labkey-text-link").href(url.getActionURL()));
32+
out.write(LinkBuilder.labkeyLink("View In Genome Browser", url.getActionURL()));
3233
}
3334
}
3435
};

mGAP/src/org/labkey/mgap/query/VariantListJBrowseDisplayColumnFactory.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import org.labkey.api.query.DetailsURL;
1313
import org.labkey.api.query.FieldKey;
1414
import org.labkey.api.util.HtmlString;
15-
import org.labkey.api.util.PageFlowUtil;
15+
import org.labkey.api.util.LinkBuilder;
1616
import org.labkey.api.writer.HtmlWriter;
1717

1818
import java.util.List;
@@ -68,15 +68,15 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
6868
if (jbrowseId != null)
6969
{
7070
DetailsURL url = DetailsURL.fromString("/jbrowse/browser.view?database=" + jbrowseId + "&location=" + contig + ":" + start + ".." + stop + "&highlight=" + contig + ":" + position + ".." + (position + length - 1), ContainerManager.getForId(containerId));
71-
out.write(PageFlowUtil.link("View In Genome Browser").href(url.getActionURL()).addClass("labkey-text-link"));
71+
out.write(LinkBuilder.labkeyLink("View In Genome Browser", url.getActionURL()));
7272
delim = HtmlString.BR;
7373
}
7474

7575
if (primaryTrack != null)
7676
{
7777
out.write(delim);
7878
DetailsURL url = DetailsURL.fromString("/jbrowse/genotypeTable.view?trackId=" + primaryTrack + "&chr=" + contig + "&start=" + position + "&stop=" + position, ContainerManager.getForId(containerId));
79-
out.write(PageFlowUtil.link("View Genotypes At Position").href(url.getActionURL()).addClass("labkey-text-link"));
79+
out.write(LinkBuilder.labkeyLink("View Genotypes At Position", url.getActionURL()));
8080
delim = HtmlString.BR;
8181
}
8282

@@ -98,7 +98,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
9898
{
9999
String url = "https://www.ncbi.nlm.nih.gov/clinvar/variation/" + parts[1] + "/";
100100
out.write(delim);
101-
out.write(PageFlowUtil.link("View in ClinVar").href(url));
101+
out.write(LinkBuilder.labkeyLink("View in ClinVar", url));
102102
delim = HtmlString.BR;
103103
}
104104
}
@@ -111,7 +111,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
111111
contigE = contigE.replaceAll("^0", "");
112112
String url = "https://ensembl.org/Macaca_mulatta/Location/View?db=core;r=" + contigE + ":" + start +"-" + stop;
113113
out.write(delim);
114-
out.write(PageFlowUtil.link("View Region in Ensembl").href(url));
114+
out.write(LinkBuilder.labkeyLink("View Region in Ensembl", url));
115115
}
116116
};
117117
}

mGAP/src/org/labkey/mgap/query/VariantReleaseDisplayColumnFactory.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import org.labkey.api.query.DetailsURL;
1111
import org.labkey.api.query.FieldKey;
1212
import org.labkey.api.util.HtmlString;
13+
import org.labkey.api.util.LinkBuilder;
1314
import org.labkey.api.util.PageFlowUtil;
1415
import org.labkey.api.view.HttpView;
1516
import org.labkey.api.view.template.ClientDependency;
@@ -53,7 +54,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
5354
Integer rowId = ctx.get(getBoundKey("rowid"), Integer.class);
5455
if (rowId != null)
5556
{
56-
out.write(PageFlowUtil.link("Download").
57+
out.write(LinkBuilder.labkeyLink("Download").
5758
addClass("vrdc-row").
5859
attributes(PageFlowUtil.map("data-rowid", rowId.toString()))
5960
);
@@ -76,7 +77,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
7677
}
7778

7879
DetailsURL url = DetailsURL.fromString("/jbrowse/browser.view?database=" + jbrowseId, ContainerManager.getForId(containerId));
79-
out.write(PageFlowUtil.link("View In Genome Browser", url.getActionURL()));
80+
out.write(LinkBuilder.labkeyLink("View In Genome Browser", url.getActionURL()));
8081
}
8182

8283
Boolean showVariantList = ctx.get(getBoundKey("hasSignificantVariants"), Boolean.class);
@@ -85,7 +86,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
8586
out.write(HtmlString.BR);
8687

8788
DetailsURL url = DetailsURL.fromString("/mgap/variantList.view?release=" + rowId, ContainerManager.getForId(containerId));
88-
out.write(PageFlowUtil.link("Significant Variant List", url.getActionURL()));
89+
out.write(LinkBuilder.labkeyLink("Significant Variant List", url.getActionURL()));
8990
}
9091
}
9192

mGAP/src/org/labkey/mgap/query/VariantReleaseGenomeBrowserDisplayColumnFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.labkey.api.data.RenderContext;
99
import org.labkey.api.query.DetailsURL;
1010
import org.labkey.api.query.FieldKey;
11+
import org.labkey.api.util.LinkBuilder;
1112
import org.labkey.api.util.PageFlowUtil;
1213
import org.labkey.api.writer.HtmlWriter;
1314

@@ -73,7 +74,7 @@ public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
7374
if (jbrowseId != null)
7475
{
7576
DetailsURL url = DetailsURL.fromString("/jbrowse/browser.view?database=" + jbrowseId, ContainerManager.getForId(containerId));
76-
out.write(PageFlowUtil.link("View In Genome Browser", url.getActionURL()));
77+
out.write(LinkBuilder.labkeyLink("View In Genome Browser", url.getActionURL()));
7778
}
7879
}
7980

mcc/src/org/labkey/mcc/query/AnimalRequestActionsDisplayColumnFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.labkey.api.data.ColumnInfo;
66
import org.labkey.api.data.DisplayColumn;
77
import org.labkey.api.data.DisplayColumnFactory;
8+
import org.labkey.api.util.LinkBuilder;
89
import org.labkey.api.util.PageFlowUtil;
910
import org.labkey.api.writer.HtmlWriter;
1011
import org.labkey.api.data.RenderContext;
@@ -26,7 +27,7 @@ public DisplayColumn createRenderer(ColumnInfo colInfo)
2627
public void renderGridCellContents(RenderContext ctx, HtmlWriter out)
2728
{
2829
int rowId = ctx.get(getBoundKey("rowid"), Integer.class);
29-
out.write(PageFlowUtil.link("Contact MCC").href("mailto:" + MccManager.get().getMccAdminEmail() + "?subject=MCC Request #" + rowId));
30+
out.write(LinkBuilder.labkeyLink("Contact MCC", "mailto:" + MccManager.get().getMccAdminEmail() + "?subject=MCC Request #" + rowId));
3031
}
3132

3233
@Override

0 commit comments

Comments
 (0)