Fix compatibility with Minecraft 26.1.2#2
Open
GW228g wants to merge 1 commit into
Open
Conversation
- Recipe.removeRecipe(): compare by Material type instead of full ItemStack equality — old comparison never matched because recipe results are plain ItemStacks while ours carry custom meta/lore, causing 30+ startup errors - pom.xml: update Paper API to 26.1.2.build.63-stable, Java to 21, maven-shade-plugin to 3.6.0, ProtocolLib to 5.4.0-SNAPSHOT, remove hardcoded Windows output path - plugin.yml: update api-version from 1.21 to 26.1 Tested on Paper 26.1.2 build 63 with Java 25.
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Materialtype only, which is the correct intent.26.1.2.build.63-stable, bumped Java source/target to 21 (required by Paper 26.1.2), upgradedmaven-shade-pluginfrom 3.2.4 to 3.6.0 (3.2.4 cannot process Java 21 class files), updated ProtocolLib to5.4.0-SNAPSHOT(5.0.0 is no longer in any public repo), removed hardcoded Windows output path.api-versionfrom1.21to26.1to match the new Minecraft versioning scheme.Test plan
Tested on macOS with Java 25.0.3 and Paper 26.1.2 build 63.