- First test for conversion generation

Author: dash8x

src/Conversions/Jobs/PerformAttachmentConversionsJob.php

@@ -7,9 +7,8 @@
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
 use Javaabu\Mediapicker\Contracts\Attachment;
-use Spatie\MediaLibrary\Conversions\ConversionCollection;
-use Spatie\MediaLibrary\Conversions\FileManipulator;
-use Spatie\MediaLibrary\MediaCollections\Models\Media;
+use Javaabu\Mediapicker\Conversions\AttachmentConversionCollection;
+use Javaabu\Mediapicker\Conversions\MediaManipulator;
 
 class PerformAttachmentConversionsJob implements ShouldQueue
 {
@@ -20,16 +19,16 @@ class PerformAttachmentConversionsJob implements ShouldQueue
     public $deleteWhenMissingModels = true;
 
     public function __construct(
-        protected ConversionCollection $conversions,
+        protected AttachmentConversionCollection $conversions,
         protected Attachment $attachment,
         protected bool $onlyMissing = false,
     ) {}
 
-    public function handle(FileManipulator $fileManipulator): bool
+    public function handle(MediaManipulator $mediaManipulator): bool
     {
-        $fileManipulator->performConversions(
+        $mediaManipulator->performAttachmentConversions(
             $this->conversions,
-            $this->media,
+            $this->attachment,
             $this->onlyMissing
         );
 

tests/TestCase.php

@@ -9,6 +9,7 @@
 use Illuminate\Support\Facades\View;
 use Javaabu\Helpers\HelpersServiceProvider;
 use Javaabu\Mediapicker\Models\Attachment;
+use Javaabu\Mediapicker\Tests\TestSupport\Models\ModelWithConversions;
 use Javaabu\Mediapicker\Tests\TestSupport\Models\ModelWithSingleFile;
 use Javaabu\Mediapicker\Tests\TestSupport\Models\ModelWithUnacceptedFile;
 use Javaabu\Mediapicker\Tests\TestSupport\Models\ModelWithUnacceptedMimeType;
@@ -106,6 +107,11 @@ protected function getModel(): Post
         return Post::factory()->create();
     }
 
+    protected function getModelWithConversions(): ModelWithConversions
+    {
+        return ModelWithConversions::factory()->create();
+    }
+
     protected function getModelWithUnacceptedFile(): ModelWithUnacceptedFile
     {
         return ModelWithUnacceptedFile::factory()->create();

tests/TestSupport/Models/ModelWithConversions.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Javaabu\Mediapicker\Tests\TestSupport\Models;
+use Illuminate\Database\Eloquent\Factories\HasFactory;
+use Illuminate\Database\Eloquent\Model;
+use Javaabu\Mediapicker\Concerns\InteractsWithAttachments;
+use Javaabu\Mediapicker\Contracts\HasAttachments;
+use Javaabu\Mediapicker\Tests\TestSupport\Factories\PostFactory;
+use Spatie\MediaLibrary\MediaCollections\File;
+use Spatie\MediaLibrary\MediaCollections\Models\Media;
+
+class ModelWithConversions extends Post
+{
+    public function registerAttachmentConversions(?Media $media = null)
+    {
+        $this->addAttachmentConversion('test')
+            ->width(100)
+            ->height(100)
+            ->crop(100, 100);
+    }
+}

tests/Unit/Concerns/InteractsWithAttachmentsTest.php

@@ -575,4 +575,20 @@ public function it_can_scope_query_with_attachments(): void
         $result = Post::withAttachments()->first();
         $this->assertTrue($result->relationLoaded('attachments'));
     }
+
+    #[Test]
+    public function it_can_generate_attachment_conversions(): void
+    {
+        $model = $this->getModelWithConversions();
+
+        $media = $this->getMedia();
+
+        $attachment = $model->addAttachment($media)
+            ->toAttachmentCollection();
+
+        $path = $model->getFirstAttachmentPath(conversionName: 'test');
+
+        $this->assertEquals($this->getMediaDirectory($media->getKey() . '/conversions/test-test.jpg'), $path);
+        $this->assertFileExists($path);
+    }
 }