Don't set display to null because it may re-used

Ghost-chu · Ghost-chu · commit fb01eee65f3e · 2021-10-02T16:36:38.000+08:00
diff --git a/src/main/java/org/maxgamer/quickshop/shop/ContainerShop.java b/src/main/java/org/maxgamer/quickshop/shop/ContainerShop.java
@@ -360,7 +360,6 @@ public void checkDisplay() {
                 if(this.displayItem.isSpawned()){
                     this.displayItem.remove();
                 }
-                this.displayItem = null;
             }
             return;
         }
@@ -533,11 +532,9 @@ public void onUnload() {
         }
         if (inventoryPreview != null) {
             inventoryPreview.close();
-            inventoryPreview = null;
         }
         if (this.displayItem != null) {
             this.displayItem.remove();
-            this.displayItem = null;
         }
         update();
         this.isLoaded = false;

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,6 @@ public void checkDisplay() {`
`360`	`360`	`if(this.displayItem.isSpawned()){`
`361`	`361`	`this.displayItem.remove();`
`362`	`362`	`}`
`363`		`- this.displayItem = null;`
`364`	`363`	`}`
`365`	`364`	`return;`
`366`	`365`	`}`
`@@ -533,11 +532,9 @@ public void onUnload() {`
`533`	`532`	`}`
`534`	`533`	`if (inventoryPreview != null) {`
`535`	`534`	`inventoryPreview.close();`
`536`		`- inventoryPreview = null;`
`537`	`535`	`}`
`538`	`536`	`if (this.displayItem != null) {`
`539`	`537`	`this.displayItem.remove();`
`540`		`- this.displayItem = null;`
`541`	`538`	`}`
`542`	`539`	`update();`
`543`	`540`	`this.isLoaded = false;`