Fix VirualDisplayItem Bug in 1.19.3

sandtechnology · sandtechnology · commit d1b18b551502 · 2022-12-15T04:53:25.000+08:00
diff --git a/src/main/java/org/maxgamer/quickshop/shop/VirtualDisplayItem.java b/src/main/java/org/maxgamer/quickshop/shop/VirtualDisplayItem.java
@@ -479,9 +479,10 @@ private static PacketContainer createFakeItemMetaPacket(int entityID, ItemStack
                 }
                 //Convert List<WrappedWatchableObject> to List<WrappedDataValue>
                 List<WrappedWatchableObject> wrappedWatchableObjects = wpw.getWatchableObjects();
-                List<WrappedDataValue> wrappedDataValues = new java.util.ArrayList<>(wrappedWatchableObjects.size());
-                for (WrappedWatchableObject watchableObject : wrappedWatchableObjects) {
-                    wrappedDataValues.set(watchableObject.getIndex(), new WrappedDataValue(watchableObject.getHandle()));
+                List<WrappedDataValue> wrappedDataValues = new java.util.LinkedList<>();
+                for (WrappedWatchableObject wrappedWatchableObject : wrappedWatchableObjects) {
+                    WrappedDataWatcher.WrappedDataWatcherObject watchableObject = wrappedWatchableObject.getWatcherObject();
+                    wrappedDataValues.add(new WrappedDataValue(watchableObject.getIndex(), watchableObject.getSerializer(), wrappedWatchableObject.getRawValue()));
                 }
                 fakeItemMetaPacket.getDataValueCollectionModifier().write(0, wrappedDataValues);
             } else {

Original file line number	Diff line number	Diff line change
`@@ -479,9 +479,10 @@ private static PacketContainer createFakeItemMetaPacket(int entityID, ItemStack`
`479`	`479`	`}`
`480`	`480`	`//Convert List<WrappedWatchableObject> to List<WrappedDataValue>`
`481`	`481`	`List<WrappedWatchableObject> wrappedWatchableObjects = wpw.getWatchableObjects();`
`482`		`- List<WrappedDataValue> wrappedDataValues = new java.util.ArrayList<>(wrappedWatchableObjects.size());`
`483`		`- for (WrappedWatchableObject watchableObject : wrappedWatchableObjects) {`
`484`		`- wrappedDataValues.set(watchableObject.getIndex(), new WrappedDataValue(watchableObject.getHandle()));`
	`482`	`+ List<WrappedDataValue> wrappedDataValues = new java.util.LinkedList<>();`
	`483`	`+ for (WrappedWatchableObject wrappedWatchableObject : wrappedWatchableObjects) {`
	`484`	`+ WrappedDataWatcher.WrappedDataWatcherObject watchableObject = wrappedWatchableObject.getWatcherObject();`
	`485`	`+ wrappedDataValues.add(new WrappedDataValue(watchableObject.getIndex(), watchableObject.getSerializer(), wrappedWatchableObject.getRawValue()));`
`485`	`486`	`}`
`486`	`487`	`fakeItemMetaPacket.getDataValueCollectionModifier().write(0, wrappedDataValues);`
`487`	`488`	`} else {`