Apply analysis tools advise

Author: Ghost-chu

src/main/java/org/maxgamer/quickshop/QuickShop.java

@@ -349,7 +349,7 @@ private void load3rdParty() {
         }
         if (getConfiguration().getBoolean("plugin.WorldEdit")) {
             String nmsVersion = ReflectFactory.getNMSVersion();
-            GameVersion gameVersion = GameVersion.get(nmsVersion);
+          //  GameVersion gameVersion = GameVersion.get(nmsVersion);
             this.worldEditPlugin = Bukkit.getPluginManager().getPlugin("WorldEdit");
             if (this.worldEditPlugin != null) {
                 this.worldEditAdapter = new WorldEditAdapter(this, (WorldEditPlugin) this.worldEditPlugin);

src/main/java/org/maxgamer/quickshop/listener/InternalListener.java

@@ -68,7 +68,7 @@ public void shopCreate(ShopCreateEvent event) {
             return;
         }
         if (loggingAction) {
-            Player creator = plugin.getServer().getPlayer(event.getCreator());
+            //Player creator = plugin.getServer().getPlayer(event.getCreator());
             plugin.logEvent(new ShopCreationLog(event.getCreator(), event.getShop().saveToInfoStorage(), event.getShop().getLocation()));
 
         }

src/main/java/org/maxgamer/quickshop/localization/game/game/distributions/MojangDistribution.java

@@ -1,3 +1,22 @@
+/*
+ * This file is a part of project QuickShop, the name is MojangDistribution.java
+ *  Copyright (C) PotatoCraft Studio and contributors
+ *
+ *  This program is free software: you can redistribute it and/or modify it
+ *  under the terms of the GNU General Public License as published by the
+ *  Free Software Foundation, either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful, but WITHOUT
+ *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ *  FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ *  for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
 package org.maxgamer.quickshop.localization.game.game.distributions;
 
 import com.google.common.cache.Cache;
@@ -48,7 +67,6 @@ public MojangDistribution(QuickShop plugin, MojangApiMirror mirror) {
     @Nullable
     public VersionManifest getVersionManifest() {
         String url = mirror.getLauncherMetaRoot() + "/mc/game/version_manifest.json";
-        String data;
         if (requestCachePool.getIfPresent(url) != null) {
             return JsonUtil.standard().fromJson(requestCachePool.getIfPresent(url), VersionManifest.class);
         }

src/main/java/org/maxgamer/quickshop/shop/ShopLoader.java

@@ -205,16 +205,16 @@ private boolean shopNullCheck(@Nullable Shop shop) {
         return false;
     }
 
-    private @NotNull Long mean(Long[] m) {
-        long sum = 0;
-        for (Long aM : m) {
-            sum += aM;
-        }
-        if (m.length == 0) {
-            return sum;
-        }
-        return sum / m.length;
-    }
+//    private @NotNull Long mean(Long[] m) {
+//        long sum = 0;
+//        for (Long aM : m) {
+//            sum += aM;
+//        }
+//        if (m.length == 0) {
+//            return sum;
+//        }
+//        return sum / m.length;
+//    }
 
     @NotNull
     private YamlConfiguration extraUpgrade(@NotNull String extraString) {

src/main/java/org/maxgamer/quickshop/shop/ShopSignStorage.java

@@ -30,7 +30,7 @@
 @Data
 @Builder
 public class ShopSignStorage {
-    private final boolean shopSign = true;
+    private final static boolean shopSign = true;
     private String world;
     private int x;
     private int y;

src/main/java/org/maxgamer/quickshop/util/reporter/error/RollbarErrorReporter.java

@@ -26,7 +26,6 @@
 import lombok.Getter;
 import org.bukkit.Bukkit;
 import org.bukkit.plugin.InvalidPluginException;
-import org.bukkit.plugin.Plugin;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 import org.maxgamer.quickshop.QuickShop;
@@ -308,18 +307,18 @@ public void resetIgnores() {
         disable = false;
     }
 
-    private String getPluginInfo() {
-        StringBuilder buffer = new StringBuilder();
-        for (Plugin bPlugin : plugin.getServer().getPluginManager().getPlugins()) {
-            buffer
-                    .append("\t")
-                    .append(bPlugin.getName())
-                    .append("@")
-                    .append(bPlugin.isEnabled() ? "Enabled" : "Disabled")
-                    .append("\n");
-        }
-        return buffer.toString();
-    }
+//    private String getPluginInfo() {
+//        StringBuilder buffer = new StringBuilder();
+//        for (Plugin bPlugin : plugin.getServer().getPluginManager().getPlugins()) {
+//            buffer
+//                    .append("\t")
+//                    .append(bPlugin.getName())
+//                    .append("@")
+//                    .append(bPlugin.isEnabled() ? "Enabled" : "Disabled")
+//                    .append("\n");
+//        }
+//        return buffer.toString();
+//    }
 
     enum PossiblyLevel {
         CONFIRM,

src/main/java/org/maxgamer/quickshop/watcher/LogWatcher.java

@@ -45,6 +45,7 @@ public class LogWatcher extends BukkitRunnable implements AutoCloseable {
 
     private PrintWriter printWriter = null;
 
+    @edu.umd.cs.findbugs.annotations.SuppressFBWarnings("DM_DEFAULT_ENCODING")
     public LogWatcher(QuickShop plugin, File log) {
         try {
             boolean deleteFailed = false;

src/main/java/org/maxgamer/quickshop/watcher/TpsWatcher.java

@@ -30,7 +30,7 @@
 public class TpsWatcher extends BukkitRunnable {
     private final LinkedList<Double> history = new LinkedList<>();
     @SuppressWarnings("FieldCanBeLocal")
-    private final long tickInterval = 50;
+    private final static long TICK_INTERVAL = 50;
     private transient long lastPoll = System.nanoTime();
 
     public TpsWatcher() {
@@ -47,7 +47,7 @@ public void run() {
         if (history.size() > 10) {
             history.remove();
         }
-        final double tps = tickInterval * 1000000.0 / timeSpent;
+        final double tps = TICK_INTERVAL * 1000000.0 / timeSpent;
         if (tps <= 21) {
             history.add(tps);
         }