Prevent directly hook into not exists economy system even the configuration marked

Author: Ghost-chu

src/main/java/org/maxgamer/quickshop/BuiltInSolution.java

@@ -66,4 +66,15 @@ public static BootError econError() {
                 "compatible economy plugin installed to get Vault working.");
     }
 
+    /**
+     * Call îf economy system failed to load. This checks the failure reason.
+     *
+     * @return The error reason.
+     */
+    public static BootError econHandlerMissingError() {
+        // Check if Vault is installed
+        return new BootError(QuickShop.getInstance().getLogger(),
+                "The selected economy handler not installed", "Please check the configuration.");
+    }
+
 }

src/main/java/org/maxgamer/quickshop/QuickShop.java

@@ -62,6 +62,7 @@
 import org.maxgamer.quickshop.chat.platform.minedown.BungeeQuickChat;
 import org.maxgamer.quickshop.command.SimpleCommandManager;
 import org.maxgamer.quickshop.database.*;
+import org.maxgamer.quickshop.economy.EconomyProviderNotFoundException;
 import org.maxgamer.quickshop.economy.Economy_GemsEconomy;
 import org.maxgamer.quickshop.economy.Economy_TNE;
 import org.maxgamer.quickshop.economy.Economy_Vault;
@@ -497,13 +498,21 @@ public boolean loadEcon() {
                 return false;
             }
             economy = ServiceInjector.getEconomy(economy);
+            if (Objects.equals(this.bootError, BuiltInSolution.econHandlerMissingError()) || Objects.equals(this.bootError, BuiltInSolution.econError())) {
+                this.bootError = null;
+            }
         } catch (Exception e) {
-            this.getSentryErrorReporter().ignoreThrow();
-            getLogger().log(Level.WARNING, "Something going wrong when loading up economy system", e);
-            getLogger().severe("QuickShop could not hook into a economy/Not found Vault or Reserve!");
-            getLogger().severe("QuickShop CANNOT start!");
-            setupBootError(BuiltInSolution.econError(), false);
-            getLogger().severe("Plugin listeners was disabled, please fix the economy issue.");
+            if (e instanceof EconomyProviderNotFoundException) {
+                getLogger().log(Level.WARNING, "Something going wrong when loading up economy system", e);
+                getLogger().severe("Failed to hook into the Economy Handler that configuration point to!");
+                getLogger().severe("QuickShop CANNOT start!");
+                setupBootError(BuiltInSolution.econHandlerMissingError(), false);
+            } else {
+                getLogger().log(Level.WARNING, "Something going wrong when loading up economy system", e);
+                getLogger().severe("QuickShop could not hook into a economy/Not found Vault or Reserve!");
+                getLogger().severe("QuickShop CANNOT start!");
+                setupBootError(BuiltInSolution.econError(), false);
+            }
             return false;
         }
         return true;

src/main/java/org/maxgamer/quickshop/economy/EconomyProviderNotFoundException.java

@@ -0,0 +1,23 @@
+/*
+ * This file is a part of project QuickShop, the name is EconomyProviderNotFoundException.java
+ *  Copyright (C) PotatoCraft Studio and contributors
+ *
+ *  This program is free software: you can redistribute it and/or modify it
+ *  under the terms of the GNU General Public License as published by the
+ *  Free Software Foundation, either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful, but WITHOUT
+ *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ *  FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ *  for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+package org.maxgamer.quickshop.economy;
+
+public class EconomyProviderNotFoundException extends RuntimeException {
+}

src/main/java/org/maxgamer/quickshop/economy/Economy_GemsEconomy.java

@@ -24,6 +24,7 @@
 import lombok.ToString;
 import me.xanium.gemseconomy.api.GemsEconomyAPI;
 import me.xanium.gemseconomy.currency.Currency;
+import org.bukkit.Bukkit;
 import org.bukkit.OfflinePlayer;
 import org.bukkit.World;
 import org.bukkit.plugin.Plugin;
@@ -47,7 +48,7 @@ public class Economy_GemsEconomy extends AbstractEconomy {
     @Setter
     private GemsEconomyAPI api;
 
-    public Economy_GemsEconomy(@NotNull QuickShop plugin) {
+    public Economy_GemsEconomy(@NotNull QuickShop plugin) throws EconomyProviderNotFoundException {
         super();
         this.plugin = plugin;
         this.formatter = new BuiltInEconomyFormatter(plugin);
@@ -61,7 +62,10 @@ private void init() {
         this.allowLoan = plugin.getConfiguration().getBoolean("shop.allow-economy-loan");
     }
 
-    private void setupEconomy() {
+    private void setupEconomy() throws EconomyProviderNotFoundException {
+        if (Bukkit.getPluginManager().getPlugin("GemsEconomy") == null) {
+            throw new EconomyProviderNotFoundException();
+        }
         this.api = new GemsEconomyAPI();
     }
 

src/main/java/org/maxgamer/quickshop/economy/Economy_Reserve.java

@@ -62,7 +62,7 @@ public class Economy_Reserve extends AbstractEconomy {
      * @deprecated Reserve no-longer active after Minecraft 1.14.
      */
     @Deprecated
-    public Economy_Reserve(@NotNull QuickShop plugin) {
+    public Economy_Reserve(@NotNull QuickShop plugin) throws EconomyProviderNotFoundException {
         this.plugin = plugin;
         this.formatter = new BuiltInEconomyFormatter(plugin);
         plugin.getReloadManager().register(this);
@@ -71,14 +71,19 @@ public Economy_Reserve(@NotNull QuickShop plugin) {
     }
 
     @SuppressWarnings("ConstantConditions")
-    private void setup() {
+    private void setup() throws EconomyProviderNotFoundException {
         try {
+            Plugin pl = plugin.getServer().getPluginManager().getPlugin("Reserve");
+            if (pl == null) {
+                throw new EconomyProviderNotFoundException();
+            }
             Reserve re = ((Reserve) plugin.getServer().getPluginManager().getPlugin("Reserve"));
             if (re.economyProvided()) {
                 reserve = re.economy();
             }
         } catch (Exception throwable) {
             reserve = null;
+            plugin.getLogger().log(Level.SEVERE, "Failed to load up Reserve", throwable);
         }
     }
 

src/main/java/org/maxgamer/quickshop/economy/Economy_TNE.java

@@ -49,7 +49,7 @@ public class Economy_TNE extends AbstractEconomy {
     @Setter
     private TNEAPI api;
 
-    public Economy_TNE(@NotNull QuickShop plugin) {
+    public Economy_TNE(@NotNull QuickShop plugin) throws EconomyProviderNotFoundException {
         super();
         this.plugin = plugin;
         plugin.getReloadManager().register(this);
@@ -61,7 +61,12 @@ private void init() {
         this.allowLoan = plugin.getConfiguration().getBoolean("shop.allow-economy-loan");
     }
 
-    private void setupEconomy() {
+    private void setupEconomy() throws EconomyProviderNotFoundException {
+        if (Bukkit.getPluginManager().getPlugin("TNE") == null
+                && Bukkit.getPluginManager().getPlugin("TNE-Bukkit") == null
+                && Bukkit.getPluginManager().getPlugin("TheNewEconomy") == null) {
+            throw new EconomyProviderNotFoundException();
+        }
         this.api = TNE.instance().api();
     }
 

src/main/java/org/maxgamer/quickshop/economy/Economy_Vault.java

@@ -58,7 +58,7 @@ public class Economy_Vault extends AbstractEconomy implements Listener {
     private net.milkbowl.vault.economy.Economy vault;
 
 
-    public Economy_Vault(@NotNull QuickShop plugin) {
+    public Economy_Vault(@NotNull QuickShop plugin) throws EconomyProviderNotFoundException {
         super();
         this.plugin = plugin;
         this.formatter = new BuiltInEconomyFormatter(plugin);
@@ -71,15 +71,16 @@ private void init() {
         this.allowLoan = plugin.getConfiguration().getBoolean("shop.allow-economy-loan");
     }
 
-    private boolean setupEconomy() {
+    private boolean setupEconomy() throws EconomyProviderNotFoundException {
         if (!Util.isClassAvailable("net.milkbowl.vault.economy.Economy")) {
-            return false; // QUICKSHOP-YS I can't believe it broken almost a year and nobody found it, my sentry exploded.
+            throw new EconomyProviderNotFoundException();
         }
         RegisteredServiceProvider<net.milkbowl.vault.economy.Economy> economyProvider;
         try {
             economyProvider = plugin.getServer().getServicesManager().getRegistration(net.milkbowl.vault.economy.Economy.class);
         } catch (Exception e) {
-            return false;
+            plugin.getLogger().log(Level.SEVERE, "Failed to getting vault registration", e);
+            throw new EconomyProviderNotFoundException();
         }
 
         if (economyProvider != null) {

src/main/resources/plugin.yml

@@ -68,6 +68,10 @@ softdepend:
   - IridiumSkyblock
   - FabledSkyblock
   - NBTAPI
+  - TNE
+  - TNE-Bukkit
+  - TheNewEconomy
+  - GemsEconomy
 
 api-version: 1.15