Fix memory leak when writing to buffer for logs (BGHDDevelopment#5)

This fixes BGHDDevelopment#5

Author: jamezrin

balancer/src/main/java/com/jaimemartz/playerbalancer/PlayerBalancer.java

@@ -26,9 +26,8 @@
 import java.net.URL;
 import java.net.URLConnection;
 import java.nio.file.Files;
-import java.util.logging.Handler;
+import java.util.logging.FileHandler;
 import java.util.logging.Level;
-import java.util.logging.LogRecord;
 
 public class PlayerBalancer extends Plugin {
     private boolean failed = false;
@@ -37,37 +36,23 @@ public class PlayerBalancer extends Plugin {
     private SectionManager sectionManager;
     private NetworkManager networkManager;
     private ConfigurationLoader<CommentedConfigurationNode> loader;
-    private final StringBuilder logsBuilder = new StringBuilder();
 
     private FallbackCommand fallbackCommand;
-    private Command mainCommand, manageCommand, findCommand, listCommand, serverCommand;
+    private Command mainCommand, manageCommand;
     private Listener connectListener, kickListener, reloadListener, pluginMessageListener;
 
+    public static final String LOG_FILE_PATTERN = "balancer.log";
+
     @Override
     public void onLoad() {
-        Handler handler = new Handler() {
-            @Override
-            public void publish(LogRecord record) {
-                if (isLoggable(record)) {
-                    String formatted = getFormatter().format(record);
-                    logsBuilder.append(formatted);
-                }
-            }
-
-            @Override
-            public void flush() {
-                logsBuilder.setLength(0);
-            }
-
-            @Override
-            public void close() throws SecurityException {
-                //Nothing to do
-            }
-        };
-
-        handler.setFormatter(new CustomFormatter());
-        getProxy().getLogger().addHandler(handler);
-        getProxy().getLogger().setUseParentHandlers(true);
+        try {
+            FileHandler handler = new FileHandler(LOG_FILE_PATTERN);
+            handler.setFormatter(new CustomFormatter());
+            getProxy().getLogger().addHandler(handler);
+            getProxy().getLogger().setUseParentHandlers(true);
+        } catch (Exception e) {
+            getLogger().log(Level.WARNING, "Could not set custom log handler", e);
+        }
     }
 
     @Override
@@ -305,8 +290,4 @@ public NetworkManager getNetworkManager() {
     public FallbackCommand getFallbackCommand() {
         return fallbackCommand;
     }
-
-    public StringBuilder getLogsBuilder() {
-        return logsBuilder;
-    }
 }

balancer/src/main/java/com/jaimemartz/playerbalancer/helper/PasteHelper.java

@@ -14,8 +14,11 @@
 import java.io.FileInputStream;
 import java.io.InputStreamReader;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.util.function.BiConsumer;
 
+import static com.jaimemartz.playerbalancer.PlayerBalancer.LOG_FILE_PATTERN;
+
 public enum PasteHelper {
     PLUGIN((sender, address) -> {
         if (sender instanceof ProxiedPlayer) {
@@ -56,7 +59,7 @@ public URL paste(PlayerBalancer plugin) throws Exception {
         public URL paste(PlayerBalancer plugin) throws Exception {
             File file = new File("config.yml");
             try (FileInputStream stream = new FileInputStream(file)) {
-                try (InputStreamReader reader = new InputStreamReader(stream, "UTF-8")) {
+                try (InputStreamReader reader = new InputStreamReader(stream, StandardCharsets.UTF_8)) {
                     String content = CharStreams.toString(reader);
                     content = content.replaceAll("[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}", "?.?.?.?");
                     HastebinPaste paste = new HastebinPaste("https://file.properties/paste/", content);
@@ -79,11 +82,14 @@ public URL paste(PlayerBalancer plugin) throws Exception {
     }, false) {
         @Override
         public URL paste(PlayerBalancer plugin) throws Exception {
-            HastebinPaste paste = new HastebinPaste("https://file.properties/paste/",
-                    plugin.getLogsBuilder().toString()
-            );
-
-            return paste.paste();
+            File file = new File(LOG_FILE_PATTERN);
+            try (FileInputStream stream = new FileInputStream(file)) {
+                try (InputStreamReader reader = new InputStreamReader(stream, StandardCharsets.UTF_8)) {
+                    String content = CharStreams.toString(reader);
+                    HastebinPaste paste = new HastebinPaste("https://file.properties/paste/", content);
+                    return paste.paste();
+                }
+            }
         }
     };