Doku + small error for kiting units when using frameskip.

Author: Bytekeeper

build.gradle.kts

@@ -2,7 +2,7 @@ plugins {
     java
     id("maven")
     id("me.champeau.gradle.jmh") version "0.4.8"
-    id("com.github.ben-manes.versions") version "0.22.0"
+    id("com.github.ben-manes.versions") version "0.27.0"
 }
 
 group = "org.bk"
@@ -22,7 +22,7 @@ dependencies {
     implementation(fileTree("lib").include("*.jar"))
     implementation("com.github.JavaBWAPI:JBWAPI:0.8.2")
 
-    testImplementation("org.junit.jupiter:junit-jupiter:5.5.1")
+    testImplementation("org.junit.jupiter:junit-jupiter:5.5.2")
     testImplementation("org.assertj:assertj-core:3.13.2")
     testImplementation("io.jenetics:jenetics:5.0.1")
 }

src/main/java/org/bk/ass/sim/AgentUtil.java

@@ -126,11 +126,9 @@ public static void dealBounceDamage(
     int damage = weapon.damageShifted / 3;
     for (int i = enemies.size() - 1; i >= 0 && remainingBounces > 0; i--) {
       Agent enemy = enemies.get(i);
-      if (enemy == lastTarget) {
-        continue;
-      }
-
-      if (abs(enemy.x - lastTarget.x) <= 96 && abs(enemy.y - lastTarget.y) <= 96) {
+      if (enemy != lastTarget
+              && abs(enemy.x - lastTarget.x) <= 96
+              && abs(enemy.y - lastTarget.y) <= 96) {
         lastTarget = enemy;
         applyDamage(enemy, weapon.damageType, damage, weapon.hits);
         damage /= 3;

src/main/java/org/bk/ass/sim/AttackerBehavior.java

@@ -112,7 +112,7 @@ private void simCombatMove(
             && selectedEnemy.speed < agent.speed;
     float distance = (float) sqrt(selectedDistanceSquared);
     if (shouldKite) {
-      if (distance + agent.speed <= selectedWeapon.maxRange) {
+      if (distance + agent.speed * frameSkip <= selectedWeapon.maxRange) {
         moveAwayFrom(frameSkip, agent, selectedEnemy, distance);
       }
     } else {

src/main/java/org/bk/ass/sim/RetreatBehavior.java

@@ -28,7 +28,7 @@ static boolean simFlee(int frames, Agent agent, UnorderedCollection<Agent> enemi
           selectedDistanceSquared = distanceSq;
           selectedEnemy = enemy;
 
-          // If we can hit it this frame, we're done searching
+          // If the enemy can hit us this frame, we're done searching
           if (selectedDistanceSquared <= wpn.maxRangeSquared) {
             break;
           }

src/main/java/org/bk/ass/sim/Simulator.java

@@ -207,7 +207,7 @@ private void updateStats(UnorderedCollection<Agent> agents) {
       agent.vy = 0;
       agent.healedThisFrame = false;
 
-      // Since these calls are potentially made every frame, no boundary checks are done!
+      // Since these calls are potentially made every frame, no boundary checks are done for performance reasons!
       // Bounds are established when the fields are modified.
       agent.cooldown -= frameSkip;
       agent.shieldsShifted += 7 * frameSkip;