Skip to content

Commit 2ba5c14

Browse files
committed
fix(dependencies): update package versions and refactor tests
Update package versions and refactor test code for clarity and consistency. - Updated the version of the `BigBook` package to `6.0.6`. - Updated the version of the `FileCurator` package to `5.0.7`. - Changed initialization of `TheoryData<object>` to shorthand syntax. - Replaced `.ConfigureAwait(false)` with direct async calls in `SQLHelperAsyncTests.cs`. - Changed loop variable from `x` to `X` for consistency across test files. - Updated assertions to use the new loop variable `X`. - Improved readability and maintainability of asynchronous calls.
1 parent f5c181f commit 2ba5c14

5 files changed

Lines changed: 80 additions & 80 deletions

File tree

src/SQLHelper.DB/SQLHelper.DB.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<PackageReference Include="SQLParser" Version="4.0.1" />
6262
<PackageReference Include="System.Data.Common" Version="4.3.0" />
6363
<PackageReference Include="System.Dynamic.Runtime" Version="4.3.0" />
64-
<PackageReference Include="BigBook" Version="6.0.5" />
64+
<PackageReference Include="BigBook" Version="6.0.6" />
6565
<PackageReference Include="Microsoft.Extensions.Configuration" Version="9.0.6" />
6666
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
6767
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />

test/SQLHelper.Tests/ExtensionMethods/DbCommandExtensionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace SQLHelperDB.Tests.ExtensionMethods
77
{
88
public class DbCommandExtensionTests
99
{
10-
public static readonly TheoryData<object> ParameterTypes = new TheoryData<object>()
10+
public static readonly TheoryData<object> ParameterTypes = new()
1111
{
1212
{ (sbyte)123 },
1313
{ (byte)123 },

test/SQLHelper.Tests/SQLHelper.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
4545
</PackageReference>
4646
<PackageReference Include="xunit" Version="2.9.3" />
47-
<PackageReference Include="FileCurator" Version="5.0.6" />
47+
<PackageReference Include="FileCurator" Version="5.0.7" />
4848
</ItemGroup>
4949

5050
<ItemGroup>

test/SQLHelper.Tests/SQLHelperAsyncTests.cs

Lines changed: 55 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
using Microsoft.Extensions.Configuration;
1+
using Microsoft.Data.SqlClient;
2+
using Microsoft.Extensions.Configuration;
23
using Microsoft.Extensions.DependencyInjection;
34
using Microsoft.Extensions.ObjectPool;
45
using SQLHelperDB.Tests.BaseClasses;
56
using SQLHelperDB.Tests.DataClasses;
67
using System;
78
using System.Data;
8-
using System.Data.SqlClient;
99
using System.Text;
1010
using System.Threading.Tasks;
1111
using Xunit;
@@ -34,7 +34,7 @@ SELECT scope_identity() as [ID]",
3434
new DateTime(2010, 1, 1),
3535
Guid.NewGuid(),
3636
new TimeSpan(1, 0, 0))
37-
.ExecuteScalarAsync<int>().ConfigureAwait(false);
37+
.ExecuteScalarAsync<int>();
3838
Assert.True(Result1 > 0);
3939
Instance = new SQLHelper(GetServiceProvider().GetService<ObjectPool<StringBuilder>>(), Configuration, null)
4040
.CreateBatch(SqlClientFactory.Instance, Configuration.GetConnectionString("Default"));
@@ -50,7 +50,7 @@ SELECT scope_identity() as [ID]",
5050
new DateTime(2010, 1, 1),
5151
Guid.NewGuid(),
5252
new TimeSpan(1, 0, 0))
53-
.ExecuteScalarAsync<int>().ConfigureAwait(false);
53+
.ExecuteScalarAsync<int>();
5454
Assert.True(Result1 < Result2);
5555
}
5656

@@ -73,10 +73,10 @@ public async Task ExecuteInsertAsync()
7373
new DateTime(2010, 1, 1),
7474
Guid.NewGuid(),
7575
new TimeSpan(1, 0, 0))
76-
.ExecuteScalarAsync<int>().ConfigureAwait(false);
76+
.ExecuteScalarAsync<int>();
7777
Assert.Equal(1, Result);
7878
Instance.CreateBatch();
79-
for (var x = 0; x < 50; ++x)
79+
for (var X = 0; X < 50; ++X)
8080
{
8181
Instance.AddQuery(CommandType.Text,
8282
"INSERT INTO [TestDatabase].[dbo].[TestTable](StringValue1,StringValue2,BigIntValue,BitValue,DecimalValue,FloatValue,DateTimeValue,GUIDValue,TimeSpanValue) VALUES(@0,@1,@2,@3,@4,@5,@6,@7,@8)",
@@ -90,7 +90,7 @@ public async Task ExecuteInsertAsync()
9090
Guid.NewGuid(),
9191
new TimeSpan(1, 0, 0));
9292
}
93-
Result = await Instance.ExecuteScalarAsync<int>().ConfigureAwait(false);
93+
Result = await Instance.ExecuteScalarAsync<int>();
9494
Assert.Equal(50, Result);
9595
}
9696

@@ -103,7 +103,7 @@ public async Task ExecuteScalarAsync()
103103
var TempGuid = Guid.NewGuid();
104104
var Instance = new SQLHelper(GetServiceProvider().GetService<ObjectPool<StringBuilder>>(), Configuration, null)
105105
.CreateBatch(SqlClientFactory.Instance, Configuration.GetConnectionString("Default"));
106-
for (var x = 0; x < 50; ++x)
106+
for (var X = 0; X < 50; ++X)
107107
{
108108
Instance.AddQuery(CommandType.Text,
109109
"INSERT INTO [TestDatabase].[dbo].[TestTable](StringValue1,StringValue2,BigIntValue,BitValue,DecimalValue,FloatValue,DateTimeValue,GUIDValue,TimeSpanValue) VALUES(@0,@1,@2,@3,@4,@5,@6,@7,@8)",
@@ -117,12 +117,12 @@ public async Task ExecuteScalarAsync()
117117
TempGuid,
118118
new TimeSpan(1, 0, 0));
119119
}
120-
var Result = await Instance.ExecuteScalarAsync<int>().ConfigureAwait(false);
120+
var Result = await Instance.ExecuteScalarAsync<int>();
121121
Assert.Equal(50, Result);
122122
Instance.CreateBatch();
123123
var ListResult = await Instance.AddQuery(CommandType.Text,
124124
"SELECT COUNT(*) FROM [TestDatabase].[dbo].[TestTable]")
125-
.ExecuteScalarAsync<int>().ConfigureAwait(false);
125+
.ExecuteScalarAsync<int>();
126126
Assert.Equal(50, ListResult);
127127
}
128128

@@ -135,7 +135,7 @@ public async Task ExecuteSelectAsync()
135135
var TempGuid = Guid.NewGuid();
136136
var Instance = new SQLHelper(GetServiceProvider().GetService<ObjectPool<StringBuilder>>(), Configuration, null)
137137
.CreateBatch(SqlClientFactory.Instance, Configuration.GetConnectionString("Default"));
138-
for (var x = 0; x < 50; ++x)
138+
for (var X = 0; X < 50; ++X)
139139
{
140140
Instance.AddQuery(CommandType.Text,
141141
"INSERT INTO [TestDatabase].[dbo].[TestTable](StringValue1,StringValue2,BigIntValue,BitValue,DecimalValue,FloatValue,DateTimeValue,GUIDValue,TimeSpanValue) VALUES(@0,@1,@2,@3,@4,@5,@6,@7,@8)",
@@ -149,25 +149,25 @@ public async Task ExecuteSelectAsync()
149149
TempGuid,
150150
new TimeSpan(1, 0, 0));
151151
}
152-
var Result = await Instance.ExecuteScalarAsync<int>().ConfigureAwait(false);
152+
var Result = await Instance.ExecuteScalarAsync<int>();
153153
Assert.Equal(50, Result);
154154
Instance.CreateBatch();
155155
var ListResult = await Instance.AddQuery(CommandType.Text,
156156
"SELECT * FROM [TestDatabase].[dbo].[TestTable]")
157-
.ExecuteAsync().ConfigureAwait(false);
157+
.ExecuteAsync();
158158
Assert.Single(ListResult);
159159
Assert.Equal(50, ListResult[0].Count);
160-
for (var x = 0; x < 50; ++x)
160+
for (var X = 0; X < 50; ++X)
161161
{
162-
Assert.Equal("A", ListResult[0][x].StringValue1);
163-
Assert.Equal("B", ListResult[0][x].StringValue2);
164-
Assert.Equal(10, ListResult[0][x].BigIntValue);
165-
Assert.Equal(true, ListResult[0][x].BitValue);
166-
Assert.Equal(75.12m, ListResult[0][x].DecimalValue);
167-
Assert.Equal(4.53f, ListResult[0][x].FloatValue);
168-
Assert.Equal(new DateTime(2010, 1, 1), ListResult[0][x].DateTimeValue);
169-
Assert.Equal(TempGuid, ListResult[0][x].GUIDValue);
170-
Assert.Equal(new TimeSpan(1, 0, 0), ListResult[0][x].TimeSpanValue);
162+
Assert.Equal("A", ListResult[0][X].StringValue1);
163+
Assert.Equal("B", ListResult[0][X].StringValue2);
164+
Assert.Equal(10, ListResult[0][X].BigIntValue);
165+
Assert.Equal(true, ListResult[0][X].BitValue);
166+
Assert.Equal(75.12m, ListResult[0][X].DecimalValue);
167+
Assert.Equal(4.53f, ListResult[0][X].FloatValue);
168+
Assert.Equal(new DateTime(2010, 1, 1), ListResult[0][X].DateTimeValue);
169+
Assert.Equal(TempGuid, ListResult[0][X].GUIDValue);
170+
Assert.Equal(new TimeSpan(1, 0, 0), ListResult[0][X].TimeSpanValue);
171171
}
172172
}
173173

@@ -181,15 +181,15 @@ public async Task ExecuteSelectHundredsOfParamtersAsync()
181181
.CreateBatch(SqlClientFactory.Instance, Configuration.GetConnectionString("Default"));
182182
var Builder = new StringBuilder();
183183
var Splitter = "";
184-
for (var x = 0; x < 200; ++x)
184+
for (var X = 0; X < 200; ++X)
185185
{
186-
Builder.AppendFormat("{1}@{0}", x, Splitter);
186+
Builder.AppendFormat("{1}@{0}", X, Splitter);
187187
Splitter = ",";
188188
}
189189
var ListResult = await Instance.AddQuery(CommandType.Text,
190190
string.Format("SELECT {0} FROM [TestDatabase].[dbo].[TestTable]", Builder.ToString()),
191191
new object[200])
192-
.ExecuteAsync().ConfigureAwait(false);
192+
.ExecuteAsync();
193193
Assert.Single(ListResult);
194194
}
195195

@@ -202,7 +202,7 @@ public async Task ExecuteSelectToObjectTypeAsync()
202202
var TempGuid = Guid.NewGuid();
203203
var Instance = new SQLHelper(GetServiceProvider().GetService<ObjectPool<StringBuilder>>(), Configuration, null)
204204
.CreateBatch(SqlClientFactory.Instance, Configuration.GetConnectionString("Default"));
205-
for (var x = 0; x < 50; ++x)
205+
for (var X = 0; X < 50; ++X)
206206
{
207207
Instance.AddQuery(CommandType.Text,
208208
"INSERT INTO [TestDatabase].[dbo].[TestTable](StringValue1,StringValue2,BigIntValue,BitValue,DecimalValue,FloatValue,DateTimeValue,GUIDValue,TimeSpanValue) VALUES(@0,@1,@2,@3,@4,@5,@6,@7,@8)",
@@ -216,26 +216,26 @@ public async Task ExecuteSelectToObjectTypeAsync()
216216
TempGuid,
217217
new TimeSpan(1, 0, 0));
218218
}
219-
var Result = await Instance.ExecuteScalarAsync<int>().ConfigureAwait(false);
219+
var Result = await Instance.ExecuteScalarAsync<int>();
220220
Assert.Equal(50, Result);
221221
Instance.CreateBatch();
222222
var ListResult = await Instance.AddQuery(CommandType.Text,
223223
"SELECT * FROM [TestDatabase].[dbo].[TestTable]")
224-
.ExecuteAsync().ConfigureAwait(false);
224+
.ExecuteAsync();
225225
Assert.Single(ListResult);
226226
Assert.Equal(50, ListResult[0].Count);
227227
var ConvertedResult = ListResult[0].ConvertAll(x => (TestTableClass)x);
228-
for (var x = 0; x < 50; ++x)
228+
for (var X = 0; X < 50; ++X)
229229
{
230-
Assert.Equal("A", ConvertedResult[x].StringValue1);
231-
Assert.Equal("B", ConvertedResult[x].StringValue2);
232-
Assert.Equal(10, ConvertedResult[x].BigIntValue);
233-
Assert.True(ConvertedResult[x].BitValue);
234-
Assert.Equal(75.12m, ConvertedResult[x].DecimalValue);
235-
Assert.Equal(4.53f, ConvertedResult[x].FloatValue);
236-
Assert.Equal(new DateTime(2010, 1, 1), ConvertedResult[x].DateTimeValue);
237-
Assert.Equal(TempGuid, ConvertedResult[x].GUIDValue);
238-
Assert.Equal(new TimeSpan(1, 0, 0), ConvertedResult[x].TimeSpanValue);
230+
Assert.Equal("A", ConvertedResult[X].StringValue1);
231+
Assert.Equal("B", ConvertedResult[X].StringValue2);
232+
Assert.Equal(10, ConvertedResult[X].BigIntValue);
233+
Assert.True(ConvertedResult[X].BitValue);
234+
Assert.Equal(75.12m, ConvertedResult[X].DecimalValue);
235+
Assert.Equal(4.53f, ConvertedResult[X].FloatValue);
236+
Assert.Equal(new DateTime(2010, 1, 1), ConvertedResult[X].DateTimeValue);
237+
Assert.Equal(TempGuid, ConvertedResult[X].GUIDValue);
238+
Assert.Equal(new TimeSpan(1, 0, 0), ConvertedResult[X].TimeSpanValue);
239239
}
240240
}
241241

@@ -247,7 +247,7 @@ public async Task ExecuteUpdateAsync()
247247
.Build();
248248
var Instance = new SQLHelper(GetServiceProvider().GetService<ObjectPool<StringBuilder>>(), Configuration, null)
249249
.CreateBatch(SqlClientFactory.Instance, Configuration.GetConnectionString("Default"));
250-
for (var x = 0; x < 50; ++x)
250+
for (var X = 0; X < 50; ++X)
251251
{
252252
Instance.AddQuery(CommandType.Text,
253253
"INSERT INTO [TestDatabase].[dbo].[TestTable](StringValue1,StringValue2,BigIntValue,BitValue,DecimalValue,FloatValue,DateTimeValue,GUIDValue,TimeSpanValue) VALUES(@0,@1,@2,@3,@4,@5,@6,@7,@8)",
@@ -261,13 +261,13 @@ public async Task ExecuteUpdateAsync()
261261
Guid.NewGuid(),
262262
new TimeSpan(1, 0, 0));
263263
}
264-
var Result = await Instance.ExecuteScalarAsync<int>().ConfigureAwait(false);
264+
var Result = await Instance.ExecuteScalarAsync<int>();
265265
Assert.Equal(50, Result);
266266
Instance.CreateBatch();
267267
Result = await Instance.AddQuery(CommandType.Text,
268268
"UPDATE [TestDatabase].[dbo].[TestTable] SET StringValue1=@0",
269269
"C")
270-
.ExecuteScalarAsync<int>().ConfigureAwait(false);
270+
.ExecuteScalarAsync<int>();
271271
Assert.Equal(50, Result);
272272
}
273273

@@ -280,7 +280,7 @@ public async Task InsertWithAtSymbolAsync()
280280
var TempGuid = Guid.NewGuid();
281281
var Instance = new SQLHelper(GetServiceProvider().GetService<ObjectPool<StringBuilder>>(), Configuration, null)
282282
.CreateBatch(SqlClientFactory.Instance, Configuration.GetConnectionString("Default"));
283-
for (var x = 0; x < 50; ++x)
283+
for (var X = 0; X < 50; ++X)
284284
{
285285
Instance.AddQuery(CommandType.Text,
286286
"INSERT INTO [TestDatabase].[dbo].[TestTable](StringValue1,StringValue2,BigIntValue,BitValue,DecimalValue,FloatValue,DateTimeValue,GUIDValue,TimeSpanValue) VALUES('email@address.com',@0,@1,@2,@3,@4,@5,@6,@7)",
@@ -293,25 +293,25 @@ public async Task InsertWithAtSymbolAsync()
293293
TempGuid,
294294
new TimeSpan(1, 0, 0));
295295
}
296-
var Result = await Instance.ExecuteScalarAsync<int>().ConfigureAwait(false);
296+
var Result = await Instance.ExecuteScalarAsync<int>();
297297
Assert.Equal(50, Result);
298298
Instance.CreateBatch();
299299
var ListResult = await Instance.AddQuery(CommandType.Text,
300300
"SELECT * FROM [TestDatabase].[dbo].[TestTable]")
301-
.ExecuteAsync().ConfigureAwait(false);
301+
.ExecuteAsync();
302302
Assert.Single(ListResult);
303303
Assert.Equal(50, ListResult[0].Count);
304-
for (var x = 0; x < 50; ++x)
304+
for (var X = 0; X < 50; ++X)
305305
{
306-
Assert.Equal("email@address.com", ListResult[0][x].StringValue1);
307-
Assert.Equal("email@address.com", ListResult[0][x].StringValue2);
308-
Assert.Equal(10, ListResult[0][x].BigIntValue);
309-
Assert.Equal(true, ListResult[0][x].BitValue);
310-
Assert.Equal(75.12m, ListResult[0][x].DecimalValue);
311-
Assert.Equal(4.53f, ListResult[0][x].FloatValue);
312-
Assert.Equal(new DateTime(2010, 1, 1), ListResult[0][x].DateTimeValue);
313-
Assert.Equal(TempGuid, ListResult[0][x].GUIDValue);
314-
Assert.Equal(new TimeSpan(1, 0, 0), ListResult[0][x].TimeSpanValue);
306+
Assert.Equal("email@address.com", ListResult[0][X].StringValue1);
307+
Assert.Equal("email@address.com", ListResult[0][X].StringValue2);
308+
Assert.Equal(10, ListResult[0][X].BigIntValue);
309+
Assert.Equal(true, ListResult[0][X].BitValue);
310+
Assert.Equal(75.12m, ListResult[0][X].DecimalValue);
311+
Assert.Equal(4.53f, ListResult[0][X].FloatValue);
312+
Assert.Equal(new DateTime(2010, 1, 1), ListResult[0][X].DateTimeValue);
313+
Assert.Equal(TempGuid, ListResult[0][X].GUIDValue);
314+
Assert.Equal(new TimeSpan(1, 0, 0), ListResult[0][X].TimeSpanValue);
315315
}
316316
}
317317
}

0 commit comments

Comments
 (0)