UDUNITS2_XML_PATH should be set in environment #1842
Description
Description
In testing spack-stack-v2 at NAS, I found that many of the MAPL unit tests were failing. The failure was tracked down to UDUNITS2_XML_PATH not being set in the environment.
The most common way to get the path to the udunits2.xml path is via UDUNITS2_XML_PATH:
https://docs.unidata.ucar.edu/udunits/current/udunits2lib.html#Obtaining
and this is how many places do it, see:
- https://ncas-cms.github.io/cfunits/3.2.5/installation.html#dependencies
- https://lagrangian.readthedocs.io/en/stable/scripts/map_of_fle.html#udunits2-xml-path
The solutions are two-fold. The "easy" solution is to update the modulefiles to have UDUNITS2_XML_PATH set. This is simple for spack-stack 2.0
The long-term solution is to have the udunits spack package. I'll make a PR to the mother package repo and we can get that in 2.1. → spack/spack-packages#2729
To Reproduce
- Build spack-stack-2.0
- Install
pfunit +mpi +fhamcrest - Build MAPL
- Run the unit tests
Expected behavior
The unit tests should pass. (NOTE: a couple still fail. There is something weird in spack-stack and netcdf-c that I'm tracking down, but it's not a crucial failure.)
System, compiler, code, ...
This is with ifort 2021.13 and MPT 2.30 at NAS with spack-stack 2.0