passing py::object by reference

Author: fschlimb

src/EWBinOp.cpp

@@ -113,7 +113,7 @@ namespace x {
     };
 } // namespace x
 
-tensor_i::ptr_type EWBinOp::op(EWBinOpId op, x::DPTensorBaseX::ptr_type a, py::object b)
+tensor_i::ptr_type EWBinOp::op(EWBinOpId op, x::DPTensorBaseX::ptr_type a, py::object & b)
 {
     auto bb = x::mk_tx(b);
     return TypeDispatch<x::EWBinOp>(a, bb, op);

src/IEWBinOp.cpp

@@ -62,7 +62,7 @@ namespace x {
     };
 } // namespace x
 
-void IEWBinOp::op(IEWBinOpId op, x::DPTensorBaseX::ptr_type a, py::object b)
+void IEWBinOp::op(IEWBinOpId op, x::DPTensorBaseX::ptr_type a, py::object & b)
 {
     auto bb = x::mk_tx(b);
     TypeDispatch<x::IEWBinOp>(a, bb, op);

src/include/ddptensor/Operations.hpp

@@ -15,12 +15,12 @@ struct Creator
 
 struct IEWBinOp
 {
-    static void op(IEWBinOpId op, x::DPTensorBaseX::ptr_type a, py::object b);
+    static void op(IEWBinOpId op, x::DPTensorBaseX::ptr_type a, py::object & b);
 };
 
 struct EWBinOp
 {
-    static tensor_i::ptr_type op(EWBinOpId op, x::DPTensorBaseX::ptr_type a, py::object b);
+    static tensor_i::ptr_type op(EWBinOpId op, x::DPTensorBaseX::ptr_type a, py::object & b);
 };
 
 struct EWUnyOp

src/include/ddptensor/x.hpp

@@ -271,12 +271,12 @@ namespace x
 
     static DPTensorBaseX::ptr_type mk_tx(py::object & b)
     {
-        if(py::isinstance<x::DPTensorBaseX::ptr_type>(b)) {
-            return b.cast<x::DPTensorBaseX::ptr_type>();
+        if(py::isinstance<DPTensorBaseX>(b)) {
+            return b.cast<DPTensorBaseX::ptr_type>();
         } else if(py::isinstance<py::float_>(b)) {
-            return x::operatorx<double>::mk_tx(b);
+            return operatorx<double>::mk_tx(b);
         } else if(py::isinstance<py::int_>(b)) {
-            return x::operatorx<int64_t>::mk_tx(b);
+            return operatorx<int64_t>::mk_tx(b);
         }
         throw std::runtime_error("Invalid right operand to elementwise binary operation");
     };