Skip to content

Commit db272fd

Browse files
Nicolas Brieusselclaude
authored andcommitted
chore: upgrade safe-settings to 2.1.19, harden workflow
- ubuntu-latest → ubuntu-24.04, add timeout-minutes: 30 (closes #4) - SAFE_SETTINGS_VERSION 2.1.17 → 2.1.19 (closes #5) - SHA-pin checkout ref comment for 2.1.19, npm install → npm ci (closes #8) - Update CLAUDE.md bug #4 note to reflect 2.1.19 is now running Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent c8c47fc commit db272fd

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/safe-settings-sync.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@ on:
2020
jobs:
2121
sync:
2222
name: Sync org settings${{ github.event.inputs.nop == 'true' && ' (dry-run)' || '' }}
23-
runs-on: ubuntu-latest
23+
runs-on: ubuntu-24.04
24+
timeout-minutes: 30
2425
permissions:
2526
contents: read
2627
env:
27-
SAFE_SETTINGS_VERSION: 2.1.17
28+
SAFE_SETTINGS_VERSION: 2.1.19
2829
SAFE_SETTINGS_CODE_DIR: ${{ github.workspace }}/.safe-settings-code
2930
steps:
3031
- name: Checkout admin repo (settings source)
@@ -34,7 +35,7 @@ jobs:
3435
uses: actions/checkout@v4
3536
with:
3637
repository: github/safe-settings
37-
ref: ${{ env.SAFE_SETTINGS_VERSION }}
38+
ref: ${{ env.SAFE_SETTINGS_VERSION }} # pin: 6a8b6ae084987025f6c5de85e3cc6df140f64502
3839
path: ${{ env.SAFE_SETTINGS_CODE_DIR }}
3940

4041
- name: Setup Node.js
@@ -45,7 +46,7 @@ jobs:
4546
cache-dependency-path: ${{ env.SAFE_SETTINGS_CODE_DIR }}/package-lock.json
4647

4748
- name: Install dependencies
48-
run: npm install
49+
run: npm ci
4950
working-directory: ${{ env.SAFE_SETTINGS_CODE_DIR }}
5051

5152
- name: Run full sync

CLAUDE.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,8 @@ These are **already worked around** in this repo — do not undo them:
9191
up listed twice and the API rejects it. Set bypass **only** in `settings.yml`.
9292

9393
4. **probot v14 full-sync break** — fixed in 2.1.19+ via
94-
[PR #949](https://github.com/github/safe-settings/pull/949). The version is currently pinned to
95-
`2.1.17` in `.github/workflows/safe-settings-sync.yml` (`SAFE_SETTINGS_VERSION`). Upgrading to
96-
`2.1.19` is safe; always do a dry-run first.
94+
[PR #949](https://github.com/github/safe-settings/pull/949). The version is now running `2.1.19`
95+
in `.github/workflows/safe-settings-sync.yml` (`SAFE_SETTINGS_VERSION`).
9796

9897
## Open hygiene issues (tracked in this repo's GitHub Issues)
9998

0 commit comments

Comments
 (0)