Should commit on pressing `↵ Enter`

[ShekharReddy4]

Usually, Who use this extension don't want to change the default text for the link or the commit message. So, it is better to add an enhancement so that a ctrl+shift+L and ↵ Enter should commit the like on the repo.

[ShekharReddy4]

if possible, I will submit a patch for the same. :)

[tunnckoCore]

here's the secret

the onclick on Save button

like-on-github/like-on-github.js

Lines 390 to 410 in cd781c1

	// hide the switcher on blurring of input
	$(document).on('click', Config.EX_BTN_SAVE, function () {
	let saveBtn = $(Config.EX_BTN_SAVE);
	if (saveBtn.hasClass('saving') || !Helper.isFormValid()) {
	return false;
	}
	Helper.resetPopupHtml();
	saveBtn.addClass('saving').text('Saving...');
	Storage.getRepoUrl(function (items) {
	// commit the like
	if (items) {
	Repo.commitLike(items);
	}
	});
	});

the Ctrl+Shift+L

like-on-github/like-on-github.js

Lines 413 to 428 in cd781c1

	key(Config.MASTER_KEY, function () {
	Helper.showPopup();
	$(Config.EX_INPUT_TITLE).focus();
	// get the active tab
	ActiveTab.get(function (activeTab) {
	if (!activeTab) {
	return false;
	}
	$(Config.EX_INPUT_TITLE).val(activeTab.title);
	$(Config.EX_INPUT_URL).val(activeTab.url);
	$(Config.EX_INPUT_COMMENT).val('New Link: ' + activeTab.title);
	});

So we can just remove the MASTER_KEY handler and set the onclick handler. So when C+S+L you get just directly commit the like :D

[willowj]

find this code in like-on-github.js

          bindUI: function () {
                // close on escape key
                $(document).on('keyup', function (e) {
                    if (e.keyCode === Config.ESCAPE_KEY) {
                        Helper.closePopup();
                    }
                });

add next code, can bind enter key to save

                $(document).on('keyup', function (e) {
                    if (e.keyCode === 13) {
                       $(Config.EX_BTN_SAVE).click();
                    }
                });