CRYOSMS: Improve comms issues #8892
Description
Issue Description
As someone using this system I keep getting mismatches on the comms, which can make the system unstable, I want it to be stable and reliable for confidence of use.
How & Where?
It can be seen on all the systems using these PSUs that every so often (ranging from once every few days, to getting stuck in it for hours on end) the comms gets out of step in some way. This can be either getting surplus data through, or missing some characters, both can be seen looking through the logs on LET and HIFI Cryomag in December.
Reproducible (Yes/No)?
Unsure, but it should be possible to add this to the emulator and tests as specific issues to generate and respond to.
Additional Information
Recommendations to fix this:
- Make sure that the emulator and tests are happy on your system, tests all pass, running in DEVSIM allows you to interact with the device sensibly
- Reproduce the errors in the emulator, see them in an IOC when running in DEVSIM
- Adjust the protocol file by ignoring surplus characters and see if that helps for surplus characters
- Adjust the protocol file to be more flexible for missing characters
- Consider finding a way to flush the output buffer before sending values if there is time.
Acceptance Criteria
- The recommendations are worked through
- Every response in the emulator can send extra or fewer characters than expected
- Every response is tested for both extra and fewer characters
- Changes to the protocol file are checked in if they work
- There are tasks to patch this changed protocol file to both LET and HIFI-CRYOMAG if it works
How to Review
Before making a PR...
- Provide verbose instructions for the reviewer to test that your changes work and fix the issue
- Describe if/how you have implemented testing for this issue
- Provide screenshots of the feature to help the reviewer if relevant
If not applicable, write "Not applicable"
...
To the reviewer: Make sure to update submodules!