Skip to content

Commit f29ad91

Browse files
committed
Revert "Isolate set default template functional test"
This reverts commit 5a9f204.
1 parent 0dccf99 commit f29ad91

1 file changed

Lines changed: 13 additions & 34 deletions

File tree

test/functional/templates/SetTemplateAsDefault.test.ts

Lines changed: 13 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@ import {
99
import { CreateTemplateDTO } from '../../../src/templates/domain/dtos/CreateTemplateDTO'
1010
import { MetadataFieldTypeClass } from '../../../src/metadataBlocks/domain/models/MetadataBlock'
1111
import { deleteDatasetTemplateViaApi } from '../../testHelpers/datasets/datasetTemplatesHelper'
12-
import {
13-
createCollectionViaApi,
14-
deleteCollectionViaApi
15-
} from '../../testHelpers/collections/collectionHelper'
1612

1713
describe('SetTemplateAsDefault.execute', () => {
14+
const collectionIdOrAlias = ':root'
15+
1816
beforeEach(async () => {
1917
ApiConfig.init(
2018
TestConstants.TEST_API_URL,
@@ -25,7 +23,6 @@ describe('SetTemplateAsDefault.execute', () => {
2523

2624
test('should set the default template for a collection', async () => {
2725
const templateName = `TestDefaultTemplate-${Date.now()}`
28-
const collectionIdOrAlias = `setTemplateDefault${Date.now()}`
2926
const templateDto: CreateTemplateDTO = {
3027
name: templateName,
3128
isDefault: false,
@@ -58,39 +55,21 @@ describe('SetTemplateAsDefault.execute', () => {
5855
]
5956
}
6057

61-
let createdTemplateId: number | undefined
62-
let collectionCreated = false
63-
64-
try {
65-
await createCollectionViaApi(collectionIdOrAlias)
66-
collectionCreated = true
67-
await createTemplate.execute(templateDto, collectionIdOrAlias)
68-
const templatesAfterCreate = await getTemplatesByCollectionId.execute(collectionIdOrAlias)
69-
const createdTemplate = templatesAfterCreate.find(
70-
(template) => template.name === templateName
71-
)
58+
await createTemplate.execute(templateDto, collectionIdOrAlias)
59+
const templatesAfterCreate = await getTemplatesByCollectionId.execute(collectionIdOrAlias)
60+
const createdTemplate = templatesAfterCreate.find((template) => template.name === templateName)
7261

73-
if (!createdTemplate) {
74-
throw new Error('Created template was not found in collection templates.')
75-
}
62+
if (!createdTemplate) {
63+
throw new Error('Created template was not found in collection templates.')
64+
}
7665

77-
createdTemplateId = createdTemplate.id
66+
await setTemplateAsDefault.execute(createdTemplate.id, collectionIdOrAlias)
7867

79-
await setTemplateAsDefault.execute(createdTemplate.id, collectionIdOrAlias)
68+
const templatesAfterSet = await getTemplatesByCollectionId.execute(collectionIdOrAlias)
69+
const updatedTemplate = templatesAfterSet.find((template) => template.id === createdTemplate.id)
8070

81-
const templatesAfterSet = await getTemplatesByCollectionId.execute(collectionIdOrAlias)
82-
const updatedTemplate = templatesAfterSet.find(
83-
(template) => template.id === createdTemplate.id
84-
)
71+
expect(updatedTemplate?.isDefault).toBe(true)
8572

86-
expect(updatedTemplate?.isDefault).toBe(true)
87-
} finally {
88-
if (createdTemplateId !== undefined) {
89-
await deleteDatasetTemplateViaApi(createdTemplateId)
90-
}
91-
if (collectionCreated) {
92-
await deleteCollectionViaApi(collectionIdOrAlias)
93-
}
94-
}
73+
await deleteDatasetTemplateViaApi(createdTemplate.id)
9574
})
9675
})

0 commit comments

Comments
 (0)