update at_api_keys table to allow for a key_id column#135
Open
adamkorynta wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@MikeNeilson - I don't see any usages of set_session_user_apikey and my understanding is that CDA is now the only place for managing apikeys so it should be safe to delete? |
Contributor
Yeah, I only see one usage within the test, but CDA validates the key then just uses the _direct method. |
MikeNeilson
reviewed
Apr 6, 2026
MikeNeilson
approved these changes
May 12, 2026
this will allow for rapid lookup via CDA when attempting to check secret_hash also rename apikey column to secret_hash in order to explicitly call out apikeys being hashed. update secret hash size to 512 to be well over the bounds of argon2 hashing. Update to only allow moving the EXPIRES backwards as we do not want to be able to resurrect expired keys
fix apikey view fix unit test on at_api_keys
MikeNeilson
force-pushed
the
feature/update_apikeys_kid
branch
from
773b77a to
ff24513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXPIRESfield backwards as we do not want to allow resurrection of expired keys