Skip to content

Offset, TargetOffset and other options are not passed on the Tether #166

@talbet

Description

@talbet

I cannot get the 'offset' option, which is documented in Tether, to work while using Drop. It looks like the Drop constructor calls the Tether constructor with a set of default options that are incorrectly merged with the parameters passed to the Drop constructor.

The Tether constructor is called here

      if (this.options.tetherOptions !== false) {
        this.tether = new Tether(extend({}, opts, this.options.tetherOptions));
      }

But this.options.tetherOptions will always be an empty object (it is initialised, but never referenced anywhere else in the code).

It looks like it should be merged with this.options instead?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions