document last fix and add webdriver tests to prove the changes with real browsers

rbri · rbri · commit cb087e1d21e6 · 2026-05-25T16:06:23.000+02:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,14 @@
 
     <body>
         <release version="5.1.0" date="June xx, 2026" description="Bugfixes">
+            <action type="fix" dev="Lai Quang Duong">
+                Fix Location.setHash() to update the page's WebRequest URL when the hash changes,
+                ensuring page.getUrl() reflects the current hash.
+            </action>
+            <action type="fix" dev="Lai Quang Duong">
+                Fix WebClient.makeWebResponseForAboutUrl() to properly handle about:blank with hash fragments
+                (e.g., about:blank#foo) instead of throwing MalformedURLException.
+            </action>
             <action type="fix" dev="RhinoTeam">
                 core-js: Array spread throws TypeError on non-iterable, null, or undefined targets.
             </action>
diff --git a/src/test/java/org/htmlunit/javascript/host/Location2Test.java b/src/test/java/org/htmlunit/javascript/host/Location2Test.java
@@ -1489,9 +1489,9 @@ public void reloadGetHashChanged() throws Exception {
     @Test
     @Alerts(DEFAULT = {"1", "2", "3", "a.html?urlParam=urlVal",
                        "4", "http://§§URL§§", "http://§§URL§§/second/a.html?urlParam=urlVal", "§§URL§§"},
-            FF = {"1", "2", "2", "a.html?urlParam=urlVal",
+            FF = {"1", "2", "3", "a.html?urlParam=urlVal",
                   "4", "http://§§URL§§", "http://§§URL§§/", "§§URL§§"},
-            FF_ESR = {"1", "2", "2", "a.html?urlParam=urlVal",
+            FF_ESR = {"1", "2", "3", "a.html?urlParam=urlVal",
                       "4", "http://§§URL§§", "http://§§URL§§/", "§§URL§§"})
     public void reloadPost() throws Exception {
         final String form = DOCTYPE_HTML
@@ -1691,4 +1691,82 @@ public void ownPropertyDescriptor() throws Exception {
         expandExpectedAlertsVariables(URL_FIRST);
         loadPageVerifyTitle2(html);
     }
+
+    /**
+     * Verifies that modifying <tt>window.location.hash</tt> works, but that it doesn't
+     * force the page to reload from the server. This is very important for the Dojo
+     * unit tests, which will keep reloading themselves if the page gets reloaded.
+     *
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts({"", "#b"})
+    public void setHash() throws Exception {
+        final String html = DOCTYPE_HTML
+            + "<html><head>\n"
+            + "<script>\n"
+            + LOG_TITLE_FUNCTION
+            + "</script>\n"
+            + "</head>\n"
+            + "<body>\n"
+            + "<a id='a' onclick='log(location.hash);location.hash=\"b\";log(location.hash);'>go</a>\n"
+            + "<h2 id='b'>...</h2>\n"
+            + "</body>\n"
+            + "</html>";
+
+        final WebDriver driver = loadPage2(html);
+        driver.findElement(By.id("a")).click();
+
+        verifyTitle2(driver, getExpectedAlerts());
+
+        assertEquals(URL_FIRST, getMockWebConnection().getLastWebRequest().getUrl());
+        assertEquals(1, getMockWebConnection().getRequestCount());
+    }
+
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts("§§URL§§#newHash")
+    public void setHashUpdatesPageUrl() throws Exception {
+        final String html = DOCTYPE_HTML
+            + "<html><head>\n"
+            + "<script>\n"
+            + LOG_TITLE_FUNCTION
+            + "</script>\n"
+            + "</head>\n"
+            + "<body>\n"
+            + "<a id='a' onclick='location.hash=\"newHash\"'>go</a>'>go</a>\n"
+            + "</body>\n"
+            + "</html>";
+
+        final WebDriver driver = loadPage2(html);
+        driver.findElement(By.id("a")).click();
+
+        expandExpectedAlertsVariables(URL_FIRST);
+
+        assertEquals(getExpectedAlerts()[0], driver.getCurrentUrl());
+        assertEquals(1, getMockWebConnection().getRequestCount());
+    }
+
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts({"about:blank", "about:blank#foo", "about:blank#foo"})
+    public void setHashAboutBlank() throws Exception {
+        WebDriver driver = getWebDriver();
+        driver.get("about:blank");
+
+        assertEquals(getExpectedAlerts()[0], driver.getCurrentUrl());
+        assertEquals(0, getMockWebConnection().getRequestCount());
+
+        ((JavascriptExecutor) driver).executeScript("location.hash = 'foo'");
+        assertEquals(getExpectedAlerts()[1], driver.getCurrentUrl());
+        assertEquals(0, getMockWebConnection().getRequestCount());
+
+        driver.navigate().refresh();
+        assertEquals(getExpectedAlerts()[2], driver.getCurrentUrl());
+        assertEquals(0, getMockWebConnection().getRequestCount());
+    }
 }
diff --git a/src/test/java/org/htmlunit/javascript/host/LocationTest.java b/src/test/java/org/htmlunit/javascript/host/LocationTest.java
@@ -295,6 +295,7 @@ public void setHash() throws Exception {
 
         // Verify that we didn't reload the page.
         assertTrue(page == page2);
+        assertEquals(URL_FIRST + "#b", conn.getLastWebRequest().getUrl());
         assertEquals(1, conn.getRequestCount());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -295,6 +295,7 @@ public void setHash() throws Exception {`
`295`	`295`
`296`	`296`	`// Verify that we didn't reload the page.`
`297`	`297`	`assertTrue(page == page2);`
	`298`	`+ assertEquals(URL_FIRST + "#b", conn.getLastWebRequest().getUrl());`
`298`	`299`	`assertEquals(1, conn.getRequestCount());`
`299`	`300`	`}`
`300`	`301`