Cheat: Child Link Can Hold Hylian Shield (Modern Codebase Port) #5990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Nov 27, 2025
serprex
reviewed
Jan 5, 2026
serprex
reviewed
Jan 5, 2026
soh/src/code/z_player_lib.c
Outdated
| return false; // Skip vanilla check for making child Link have the Hylian Shield on his back, allowing for it to | ||
| // be used in hand | ||
| } else { | ||
| return gSaveContext.linkAge != 0 && (this->currentShield == PLAYER_SHIELD_HYLIAN); |
Contributor
There was a problem hiding this comment.
can be return GameInteractor_Should(...) with *should = false in handler instead of doing cvar check here
Contributor
Author
There was a problem hiding this comment.
Added a new hook and changed z_player_lib.c to use that.
I'm not sure what to do with remaining direct CVar usage (adding many more hooks?)
Contributor
There was a problem hiding this comment.
Yes, long term having a mod_hooks.cpp file in Enhancements that hooks a bunch of VBs may be the way
…sters#3887) to modern codebase
* Maybe "Show Age-Dependent Equipment" is not required?
TODO: mods.cpp is going to be retired and graphics patches will need to be moved into its own cpp file eventually
…ildWithHylianShield to use that Removed unneeded gSaveContext
nclok1405
force-pushed
the
childholdshylianshield
branch
from
7a1fc15 to
9345ff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental port of Patrick12115's "Child Link Can Hold Hylian Shield" (#3887) to the modern codebase.
I also moved the category of this option from Enhancements to Cheat, and modified Octorok's projectile to be reflectable with this option.
Build Artifacts