Form violates Applicative law

[debug-ito]

Applicative "identity" law states pure id <*> v == v, but Form violates it.

This is because its (<*>) instance adds incFormId between the two actions. As a result, pure id <*> v executes v with the incremented FormId.

I think (<*>) doesn't have to do incFormId. Instead, functions like Generalized.input should call incFormId just before they get input for themselves, because it is they who need to generate new FormIds. So, incFormId, getFormInput and getFormId might as well be atomic.

[stepcut]

I believe you are correct. If you want to submit a patch, you should create it against the bifunctors branch. Otherwise you can wait until I have a chance to get around to it.

[debug-ito]

Thanks for reply!
I'm not in a hurry, so I'll wait :)