Skip to content

SEL CWS / rolling phase estimator: V/I ordering fix, optimizations, missing-data handling, and unit tests #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ritchiecarroll merged 7 commits into from
May 23, 2026
Merged

SEL CWS / rolling phase estimator: V/I ordering fix, optimizations, missing-data handling, and unit tests #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3a57743
GSF.PhasorProtocols: Updated comment
ritchiecarroll May 22, 2026
9dc9331
GSF.PhasorProtocols: Applied correct order to rolling phase estimator…
ritchiecarroll May 22, 2026
17c5e5c
GSF.PhasorProtocols: Rolling phase estimator review fixes and hot-pat…
ritchiecarroll May 22, 2026
f30586f
GSF.PhasorProtocols: Added missing-data handling to SEL CWS rolling p…
ritchiecarroll May 23, 2026
408eff7
GSF.PhasorProtocols: Added unit tests for SEL CWS rolling phase estim…
ritchiecarroll May 23, 2026
e82199d
GSF.PhasorProtocols: Implemented both phase estimation algorithms
ritchiecarroll May 23, 2026
6573d9d
GSF.PhasorProtocols: Fixed sliding DFT phase estimator stall on backw…
ritchiecarroll May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions Source/GridSolutionsFramework.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GSF.CodeGenerators", "Gener
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GenerateGrafanaFunctionsMarkdown", "Tools\GenerateGrafanaFunctionsMarkdown\GenerateGrafanaFunctionsMarkdown.csproj", "{043A366B-FA02-46F3-B108-3D4506E4B79A}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GSF.PhasorProtocols.Tests", "Libraries\Tests\GSF.PhasorProtocols.Tests\GSF.PhasorProtocols.Tests.csproj", "{D44FD581-5E06-455B-9576-7241FC801C7D}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -2742,6 +2744,24 @@ Global
{043A366B-FA02-46F3-B108-3D4506E4B79A}.Release|x64.Build.0 = Release|Any CPU
{043A366B-FA02-46F3-B108-3D4506E4B79A}.Release|x86.ActiveCfg = Release|Any CPU
{043A366B-FA02-46F3-B108-3D4506E4B79A}.Release|x86.Build.0 = Release|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Debug|Any CPU.Build.0 = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Debug|x64.ActiveCfg = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Debug|x64.Build.0 = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Debug|x86.ActiveCfg = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Debug|x86.Build.0 = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Mono|Any CPU.ActiveCfg = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Mono|Any CPU.Build.0 = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Mono|x64.ActiveCfg = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Mono|x64.Build.0 = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Mono|x86.ActiveCfg = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Mono|x86.Build.0 = Debug|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Release|Any CPU.ActiveCfg = Release|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Release|Any CPU.Build.0 = Release|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Release|x64.ActiveCfg = Release|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Release|x64.Build.0 = Release|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Release|x86.ActiveCfg = Release|Any CPU
{D44FD581-5E06-455B-9576-7241FC801C7D}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -2917,6 +2937,7 @@ Global
{FC5B2769-89FD-420B-9722-D6E0B029ABDD} = {B48642A1-1163-4E1D-948A-50EE19DCD38D}
{0D307D8D-7A4B-46C7-B51D-B80C60E9C0E9} = {7661E0F3-B021-451B-809F-035AF510D403}
{043A366B-FA02-46F3-B108-3D4506E4B79A} = {1B63485E-46C7-4185-B968-216A02396B88}
{D44FD581-5E06-455B-9576-7241FC801C7D} = {F06A2E20-D5DD-4B88-9ABC-CEE7245829E3}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {8C14640B-0B31-4754-AD2D-FA804719D3BE}
Expand Down
1 change: 1 addition & 0 deletions Source/GridSolutionsFramework.sln.DotSettings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,7 @@
<s:Boolean x:Key="/Default/UserDictionary/Words/=setpoint/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/UserDictionary/Words/=SETSUM/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/UserDictionary/Words/=SHELBYPA/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/UserDictionary/Words/=sinc/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/UserDictionary/Words/=skipdisablerealtimedata/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/UserDictionary/Words/=sourceids/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/UserDictionary/Words/=Starlynn/@EntryIndexedValue">True</s:Boolean>
Expand Down
5 changes: 4 additions & 1 deletion Source/Libraries/GSF.PhasorProtocols/GSF.PhasorProtocols.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,13 @@
<Compile Include="SelCWS\FrameParser.cs" />
<Compile Include="SelCWS\FrequencyDefinition.cs" />
<Compile Include="SelCWS\FrequencyValue.cs" />
<Compile Include="SelCWS\IEEEC37_118PhaseEstimator.cs" />
<Compile Include="SelCWS\IPhaseEstimator.cs" />
<Compile Include="SelCWS\NamespaceDoc.cs" />
<Compile Include="SelCWS\PhaseEstimate.cs" />
<Compile Include="SelCWS\PhasorDefinition.cs" />
<Compile Include="SelCWS\PhasorValue.cs" />
<Compile Include="SelCWS\RollingPhaseEstimator.cs" />
<Compile Include="SelCWS\SlidingDftPhaseEstimator.cs" />
<Compile Include="SelFastMessage\CommandFrame.cs" />
<Compile Include="SelFastMessage\Common.cs" />
<Compile Include="SelFastMessage\CommonFrameHeader.cs" />
Expand Down
4 changes: 4 additions & 0 deletions Source/Libraries/GSF.PhasorProtocols/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,12 @@
using System;
using System.Diagnostics.CodeAnalysis;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;

// Expose internal types (e.g., SlidingDftPhaseEstimator, IEEEC37_118PhaseEstimator) to the unit-test assembly
[assembly: InternalsVisibleTo("GSF.PhasorProtocols.Tests")]

// Informational attributes.
[assembly: AssemblyCompany("Grid Protection Alliance")]
[assembly: AssemblyCopyright("Copyright © GPA, 2014. All Rights Reserved.")]
Expand Down
2 changes: 1 addition & 1 deletion Source/Libraries/GSF.PhasorProtocols/ReplayTimer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public sealed class ReplayTimer

// Maximum deficit, in milliseconds, that the deadline may fall behind real
// time. This bounds the catch-up burst produced after a long stall (e.g., a
// pause/resume or a slow buffer read) while still allowing the normal buffer-
// pause/resume or a slow buffer read) while still allowing the normal buffer
// read gaps of file playback to be fully recovered so the defined frame rate
// is maintained. Raise toward infinity for unbounded catch-up; lower for
// tighter burst control at the risk of dropping below the defined rate.
Expand Down
1 change: 0 additions & 1 deletion Source/Libraries/GSF.PhasorProtocols/RequiredMemberAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#pragma warning disable

using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;

namespace System.Runtime.CompilerServices
{
Expand Down
34 changes: 34 additions & 0 deletions Source/Libraries/GSF.PhasorProtocols/SelCWS/Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
// ReSharper disable InconsistentNaming

using System;
using System.ComponentModel;
using GSF.Units.EE;

namespace GSF.PhasorProtocols.SelCWS;
Expand Down Expand Up @@ -76,6 +77,39 @@ public enum PhaseChannel
IC = 5
}

/// <summary>
/// Phase estimation algorithm used to derive synchrophasor, frequency and ROCOF components from
/// SEL CWS point-on-wave data.
/// </summary>
public enum PhaseEstimationAlgorithm
{
/// <summary>
/// Rolling sliding DFT estimator with optional EMA smoothing (see <see cref="SlidingDftPhaseEstimator"/>).
/// </summary>
[Description("Rolling sliding DFT estimator with optional EMA smoothing")]
SlidingDft,
/// <summary>
/// IEEE C37.118-2018 Annex D filter-based estimator (see <see cref="IEEEC37_118PhaseEstimator"/>).
/// </summary>
[Description("IEEE C37.118-2018 Annex D filter-based estimator")]
IEEEC37_118
}

/// <summary>
/// IEEE C37.118-2018 Annex D filter class for phasor estimation.
/// </summary>
public enum FilterClass
{
/// <summary>
/// P-class (Protection): fast response, triangular window filter.
/// </summary>
P,
/// <summary>
/// M-class (Measurement): better out-of-band rejection, Hamming-windowed sinc filter.
/// </summary>
M
}

#endregion

/// <summary>
Expand Down
Loading
Loading