fix: Separate build and SonarCloud analysis steps

- Split verify and sonar:sonar into separate steps
- Verify only builds selected modules (excluding authserver)
- SonarCloud analysis runs at root level using sonar-project.properties
- This ensures tests run properly while respecting module exclusions

Author: dfcoffin

.github/workflows/ci.yml

@@ -151,13 +151,15 @@ jobs:
           key: ${{ runner.os }}-sonar
           restore-keys: ${{ runner.os }}-sonar
 
-      - name: Build and analyze with SonarCloud
+      - name: Build modules for SonarCloud
+        run: mvn clean verify -pl openespi-common,openespi-datacustodian,openespi-thirdparty -am
+
+      - name: Analyze with SonarCloud
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         run: |
-          mvn clean verify sonar:sonar \
-            -pl openespi-common,openespi-datacustodian,openespi-thirdparty \
+          mvn sonar:sonar \
             -Dsonar.projectKey=GreenButtonAlliance_OpenESPI-GreenButton-Java \
             -Dsonar.organization=greenbuttonalliance \
             -Dsonar.host.url=https://sonarcloud.io \

.github/workflows/pr-checks.yml

@@ -80,13 +80,15 @@ jobs:
           key: ${{ runner.os }}-sonar
           restore-keys: ${{ runner.os }}-sonar
 
+      - name: Build modules for SonarCloud
+        run: mvn clean verify -pl openespi-common,openespi-datacustodian,openespi-thirdparty -am
+
       - name: Analyze with SonarCloud
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         run: |
-          mvn clean verify sonar:sonar \
-            -pl openespi-common,openespi-datacustodian,openespi-thirdparty \
+          mvn sonar:sonar \
             -Dsonar.projectKey=GreenButtonAlliance_OpenESPI-GreenButton-Java \
             -Dsonar.organization=greenbuttonalliance \
             -Dsonar.host.url=https://sonarcloud.io \