Make the compatibility_lib externally usable (#118)

Author: liyanhui1228

compatibility_lib/compatibility_lib/compatibility_store.py

@@ -123,8 +123,8 @@ def timestamp(self, timestamp: datetime.datetime):
 class CompatibilityStore:
     """Storage for package compatibility information."""
 
-    def __init__(self):
-        self._client = bigquery.Client()
+    def __init__(self, project_id=None):
+        self._client = bigquery.Client(project=project_id)
         dataset_ref = self._client.dataset(_DATASET_NAME)
 
         self._self_table_id = (

compatibility_lib/compatibility_lib/dependency_highlighter.py

@@ -92,9 +92,6 @@ def __init__(self, py_version=None, checker=None, store=None):
         if checker is None:
             checker = compatibility_checker.CompatibilityChecker()
 
-        if store is None:
-            store = compatibility_store.CompatibilityStore()
-
         self.py_version = py_version
         self._checker = checker
         self._store = store

compatibility_lib/compatibility_lib/deprecated_dep_finder.py

@@ -42,9 +42,6 @@ def __init__(self,
         if checker is None:
             checker = compatibility_checker.CompatibilityChecker()
 
-        if store is None:
-            store = compatibility_store.CompatibilityStore()
-
         self.max_workers = max_workers
         self.py_version = py_version
         self._checker = checker

compatibility_lib/compatibility_lib/test_compatibility_store.py

@@ -115,7 +115,7 @@ def test_get_packages(self):
             [pkgs[0], 'SUCCESS'],
             [pkgs[1], 'CHECK WARNING'],
         ]
-        def MockClient():
+        def MockClient(project=None):
             return mock_client
 
         patch_client = mock.patch(
@@ -134,7 +134,7 @@ def MockClient():
 
     def test_get_self_compatibility(self):
         mock_client = mock.Mock()
-        def MockClient():
+        def MockClient(project=None):
             return mock_client
 
         row = mock.Mock(
@@ -166,7 +166,7 @@ def MockClient():
     def test_get_self_compatibilities(self):
         mock_client = mock.Mock()
 
-        def MockClient():
+        def MockClient(project=None):
             return mock_client
 
         packages = [PACKAGE_1, PACKAGE_2, PACKAGE_3, PACKAGE_4]
@@ -203,7 +203,7 @@ def test_get_pair_compatibility_value_error(self):
         # raise ValueError.
         mock_client = mock.Mock()
 
-        def MockClient():
+        def MockClient(project=None):
             return mock_client
 
         patch_client = mock.patch(
@@ -220,7 +220,7 @@ def MockClient():
     def test_get_pair_compatibility(self):
         mock_client = mock.Mock()
 
-        def MockClient():
+        def MockClient(project=None):
             return mock_client
 
         row = mock.Mock(
@@ -252,7 +252,7 @@ def MockClient():
     def test_compatibility_combinations(self):
         mock_client = mock.Mock()
 
-        def MockClient():
+        def MockClient(project=None):
             return mock_client
 
         row1 = mock.Mock(
@@ -322,7 +322,7 @@ def test_save_compatibility_statuses_pair(self):
             'details': None,
         }
 
-        def MockClient():
+        def MockClient(project=None):
             return mock_client
 
         patch_client = mock.patch(
@@ -356,7 +356,7 @@ def test_save_compatibility_statuses_self(self):
             'details': None,
         }
 
-        def MockClient():
+        def MockClient(project=None):
             return mock_client
 
         patch_client = mock.patch(
@@ -400,7 +400,7 @@ def test_save_compatibility_statuses_release_time(self):
             'is_latest': True,
         }
 
-        def MockClient():
+        def MockClient(project=None):
             return mock_client
 
         patch_client = mock.patch(
@@ -416,6 +416,10 @@ def MockClient():
 
 
 class MockClient(object):
+
+    def __init__(self, project=None):
+        self.project = project
+
     def dataset(self, dataset_name):
         dataset_ref = mock.Mock()
 

compatibility_lib/compatibility_lib/utils.py

@@ -56,9 +56,6 @@ def __init__(self, py_version=None, checker=None, store=None):
         if checker is None:
             checker = compatibility_checker.CompatibilityChecker()
 
-        if store is None:
-            store = compatibility_store.CompatibilityStore()
-
         self.py_version = py_version
         self.checker = checker
         self.store = store
@@ -72,7 +69,7 @@ def _get_from_bigquery(self, package_name):
             a dict mapping from dependency package name (string) to
             the info (dict)
         """
-        if package_name in configs.PKG_LIST:
+        if self.store is not None and package_name in configs.PKG_LIST:
             depinfo = self.store.get_dependency_info(package_name)
             return depinfo
         else:
@@ -112,6 +109,7 @@ def get_dependency_info(self, package_name):
             the info (dict)
         """
         depinfo = self._get_from_bigquery(package_name)
+
         if depinfo is None:
             depinfo = self._get_from_endpoint(package_name)
         return depinfo