Use correct version comparison in save_compatibility_statuses (#229)

Author: brianquinlan

compatibility_lib/compatibility_lib/compatibility_store.py

@@ -15,6 +15,7 @@
 """Storage for package compatibility information."""
 
 import datetime
+from distutils import version
 import enum
 import itertools
 import retrying
@@ -433,11 +434,12 @@ def save_compatibility_statuses(
                 if install_name not in install_name_to_compatibility_result:
                     install_name_to_compatibility_result[install_name] = cs
                 else:
-                    old_version = self._get_package_version(
+                    old_version_string = self._get_package_version(
                         install_name_to_compatibility_result[install_name])
-                    new_version = self._get_package_version(cs)
-                    # TODO: Do not compare versions lexicographically.
-                    # Lexicographically, '10' < '9'.
+                    new_version_string = self._get_package_version(cs)
+
+                    old_version = version.StrictVersion(old_version_string)
+                    new_version = version.StrictVersion(new_version_string)
                     if new_version > old_version:
                         install_name_to_compatibility_result[install_name] = cs
 

compatibility_lib/compatibility_lib/test_compatibility_store.py

@@ -425,9 +425,9 @@ def test_save_compatibility_statuses_release_time_for_latest(self):
             status=status,
             details=None,
             dependency_info={'package4': {
-                'installed_version': '2.7.0',
+                'installed_version': '12.7.0',
                 'installed_version_time': '2018-05-12T16:26:31',
-                'latest_version': '2.7.0',
+                'latest_version': '12.7.0',
                 'current_time': '2018-07-13T17:11:29.140608',
                 'latest_version_time': '2018-05-12T16:26:31',
                 'is_latest': True,
@@ -450,9 +450,9 @@ def test_save_compatibility_statuses_release_time_for_latest(self):
         row_release_time = {
             'install_name': 'package4[gcp]',
             'dep_name': 'package4',
-            'installed_version': '2.7.0',
+            'installed_version': '12.7.0',
             'installed_version_time': '2018-05-12T16:26:31',
-            'latest_version': '2.7.0',
+            'latest_version': '12.7.0',
             'timestamp': '2018-07-13T17:11:29.140608',
             'latest_version_time': '2018-05-12T16:26:31',
             'is_latest': True,