Skip to content
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

Commit d88bb53

Browse files
authored
Revert 'Update all release time rows in a single batch' (#226)
1 parent 17164c0 commit d88bb53

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

compatibility_lib/compatibility_lib/compatibility_store.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ def _compatibility_status_to_row(
179179
return row
180180

181181
@staticmethod
182-
def _compatibility_status_to_release_time_rows(
182+
def _compatibility_status_to_release_time_row(
183183
cs: CompatibilityResult) -> List[Mapping[str, Any]]:
184184
"""Converts a CompatibilityResult into a dict which is a row for
185185
release time table."""
@@ -403,7 +403,7 @@ def save_compatibility_statuses(
403403
self._pairwise_table,
404404
pair_rows)
405405

406-
release_time_rows = []
406+
release_time_rows = {}
407407
for cs in compatibility_statuses:
408408
if len(cs.packages) == 1:
409409
install_name = cs.packages[0].install_name
@@ -413,13 +413,14 @@ def save_compatibility_statuses(
413413
if not self._should_update_dep_info(
414414
cs, release_time_rows.get(install_name)):
415415
continue
416-
rows = self._compatibility_status_to_release_time_rows(cs)
417-
release_time_rows.extend(rows)
416+
row = self._compatibility_status_to_release_time_row(cs)
417+
if row:
418+
release_time_rows[install_name] = row
418419

419-
if release_time_rows:
420+
for row in release_time_rows.values():
420421
self._client.insert_rows(
421422
self._release_time_table,
422-
release_time_rows)
423+
row)
423424

424425
def _should_update_dep_info(self, cs, dep_info_stored):
425426
"""Return True if the stored version is behind latest version."""

0 commit comments

Comments
 (0)